From: "Andrew Burgess" <aburgess@broadcom.com>
To: "Jan Kratochvil" <jan.kratochvil@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] improve python finish breakpoint for exceptions/longjmp case.
Date: Wed, 24 Oct 2012 20:48:00 -0000 [thread overview]
Message-ID: <5088540F.3040200@broadcom.com> (raw)
In-Reply-To: <20121017162748.GA6546@host2.jankratochvil.net>
Jan,
On 17/10/2012 5:27 PM, Jan Kratochvil wrote:
>
> [...]
>> +#include <pthread.h>
>> +#include <assert.h>
>> +#include <unistd.h>
>> +
>> +static volatile int blocks[2];
>> +
>> +void
>> +breakpt (int is_first_thread)
>> +{
>> + if (is_first_thread)
>> + {
>> + /* Main thread. */
>> +
>> + blocks[0] = 1; /* Set thread 2 going. */
>> + while (!blocks[1]); /* Wait for thread 2. */
>
> Also testcases should not remain hanging indefinitely if something breaks, in
> this case 'alarm (60);' at the start of 'main' should ensure that I think.
I'm confused why this test would need to take care of shutting itself down,
if the test failed would dejagnu not timeout the test, and eventually gdb
would exit taking down the inferior as it does?
I had a look for other tests that used alarm() but there are only a few and I
didn't think any of these were trying to perform a defensive shutdown as you're
suggesting, so can you point at any other test that needs to do this sort of
thing, or is there something special about this test?
Thanks,
Andrew
next prev parent reply other threads:[~2012-10-24 20:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 14:58 Andrew Burgess
2012-09-24 10:22 ` Kevin Pouget
2012-10-01 16:33 ` Andrew Burgess
2012-10-01 16:30 ` Andrew Burgess
2012-10-10 21:08 ` Andrew Burgess
2012-10-11 6:46 ` Phil Muldoon
2012-10-11 16:32 ` Jan Kratochvil
2012-10-15 20:40 ` Andrew Burgess
2012-10-17 16:28 ` Jan Kratochvil
2012-10-24 20:48 ` Andrew Burgess [this message]
2012-10-25 6:13 ` Jan Kratochvil
2012-10-25 19:23 ` Andrew Burgess
2012-10-30 17:41 ` Jan Kratochvil
2012-11-06 14:24 ` Andrew Burgess
2012-11-22 18:15 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5088540F.3040200@broadcom.com \
--to=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox