From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC 0/2, gdbserver] Set linux target in async mode in default
Date: Tue, 25 Sep 2012 16:23:00 -0000 [thread overview]
Message-ID: <5061DA66.6020106@redhat.com> (raw)
In-Reply-To: <1347961672-18495-1-git-send-email-yao@codesourcery.com>
On 09/18/2012 10:47 AM, Yao Qi wrote:
> Hi,
> When writing the V2 of 'A general notification in GDB RSP' patch
> series, I find async mode isn't turned on unless non-stop mode is
> turned on. After I generalize 'async notification' and support both
> non-stop and all-stop, it is required to turn async on even in all-stop
> mode. Async can be regarded as an infrastructure in linux target to
> serve for other functionalities, such as 'notification' and
> 'non-stop'. This is what patch 1/2 tries to do. Regression tested on
> x86_64-linux with boardfile ntaive-gdbserver and
> native-extended-gdbserver.
>
> After patch 1/2 is applied, target_async is not used in common code,
> so patch 2/2 is to remove macro target_async and field 'async' in
> struct 'target_ops' as a cleanup.
Please explain better why this is necessary (probably with an example).
What exactly doesn't work if you don't do this change? It sounds as though
this could make gdbserver push notifications down to GDB in all-stop
mode even when it isn't waiting for server replies?
--
Pedro Alves
next prev parent reply other threads:[~2012-09-25 16:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 9:49 Yao Qi
2012-09-18 9:49 ` [PATCH 1/2] gdbserver:Set " Yao Qi
2012-09-18 9:49 ` [PATCH 2/2] gdbserver:Remove async from target_ops Yao Qi
2012-09-18 14:12 ` [RFC 0/2, gdbserver] Set linux target in async mode in default Marc Khouzam
2012-09-18 14:36 ` Yao Qi
2012-09-18 14:39 ` Marc Khouzam
2012-09-25 16:23 ` Pedro Alves [this message]
2012-09-27 3:16 ` Yao Qi
2012-10-12 12:00 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5061DA66.6020106@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox