From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFC 0/2, gdbserver] Set linux target in async mode in default
Date: Fri, 12 Oct 2012 12:00:00 -0000 [thread overview]
Message-ID: <50780646.2030309@codesourcery.com> (raw)
In-Reply-To: <5061DA66.6020106@redhat.com>
On 09/26/2012 12:23 AM, Pedro Alves wrote:
> Please explain better why this is necessary (probably with an example).
> What exactly doesn't work if you don't do this change? It sounds as though
> this could make gdbserver push notifications down to GDB in all-stop
> mode even when it isn't waiting for server replies?
Pedro,
I think about your question and 'async notification' again, looks we
have two options on the timing of sending '%' notifications,
1. in server.c:handle_target_event, in which %Stop is sent,
2. in the place where something interesting happens. For example,
if we have a notification trace stop, '%Trace' notification is sent at
the end of tracepoint.c:stop_tracing.
My original design is to defer *all* notification sent in #1
(handle_target_event), so async mode should be on. Today, I find that
notifications except %Stop can be sent in #2, and don't have to put them
into #1. If this sounds reasonable to you, this patch set is useless,
and I'll revise my 'async notification' patch set in this way.
--
Yao
prev parent reply other threads:[~2012-10-12 12:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 9:49 Yao Qi
2012-09-18 9:49 ` [PATCH 2/2] gdbserver:Remove async from target_ops Yao Qi
2012-09-18 9:49 ` [PATCH 1/2] gdbserver:Set linux target in async mode in default Yao Qi
2012-09-18 14:12 ` [RFC 0/2, gdbserver] Set " Marc Khouzam
2012-09-18 14:36 ` Yao Qi
2012-09-18 14:39 ` Marc Khouzam
2012-09-25 16:23 ` Pedro Alves
2012-09-27 3:16 ` Yao Qi
2012-10-12 12:00 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50780646.2030309@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox