From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4672 invoked by alias); 25 Sep 2012 16:23:22 -0000 Received: (qmail 4626 invoked by uid 22791); 25 Sep 2012 16:23:19 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Sep 2012 16:23:06 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8PGN4Kr015390 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 25 Sep 2012 12:23:04 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8PGN2d1016426; Tue, 25 Sep 2012 12:23:03 -0400 Message-ID: <5061DA66.6020106@redhat.com> Date: Tue, 25 Sep 2012 16:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [RFC 0/2, gdbserver] Set linux target in async mode in default References: <1347961672-18495-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1347961672-18495-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00559.txt.bz2 On 09/18/2012 10:47 AM, Yao Qi wrote: > Hi, > When writing the V2 of 'A general notification in GDB RSP' patch > series, I find async mode isn't turned on unless non-stop mode is > turned on. After I generalize 'async notification' and support both > non-stop and all-stop, it is required to turn async on even in all-stop > mode. Async can be regarded as an infrastructure in linux target to > serve for other functionalities, such as 'notification' and > 'non-stop'. This is what patch 1/2 tries to do. Regression tested on > x86_64-linux with boardfile ntaive-gdbserver and > native-extended-gdbserver. > > After patch 1/2 is applied, target_async is not used in common code, > so patch 2/2 is to remove macro target_async and field 'async' in > struct 'target_ops' as a cleanup. Please explain better why this is necessary (probably with an example). What exactly doesn't work if you don't do this change? It sounds as though this could make gdbserver push notifications down to GDB in all-stop mode even when it isn't waiting for server replies? -- Pedro Alves