From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4] Delete unused functions in sol-thread.c.
Date: Mon, 24 Sep 2012 16:18:00 -0000 [thread overview]
Message-ID: <506087DE.5090900@redhat.com> (raw)
In-Reply-To: <20120920214340.GB5423@adacore.com>
On 09/20/2012 10:43 PM, Joel Brobecker wrote:
> gdb/ChangeLog:
>
> * sol-thread.c (ps_lgetxregsize, ps_lgetxregs, ps_lsetxregs):
> Enable this code for sparc hosts only.
Looks good to me, with
> +#if defined(__sparc) || defined(__sparcv9)
space before parens.
> gdb/ChangeLog:
>
> * sol-thread.c (ps_lgetxregsize, ps_lgetxregs, ps_lsetxregs):
> Remove commented-out code.
There's more '#if 0'-related code in the file. I think that if we're
removing these, we should get rid of all of it.
I found it curious that
http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/lib/libc_db/common/thread_db.c
says "Currently unused by dbx"...
--
Pedro Alves
next prev parent reply other threads:[~2012-09-24 16:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 16:34 Various build-related fixes for solaris Joel Brobecker
2012-09-20 16:34 ` [PATCH 3/4] Add procfs_find_LDT_entry declaration (procfs.h) Joel Brobecker
2012-09-22 14:22 ` Jan Kratochvil
2012-09-27 12:56 ` checked in: " Joel Brobecker
2012-09-20 16:34 ` [PATCH 1/4] Fix declaration of proc_find_memory_regions Joel Brobecker
2012-09-27 12:55 ` checked in: " Joel Brobecker
2012-09-20 16:34 ` [PATCH 2/4] Make procfs.c:proc_get_LDT_entry static Joel Brobecker
2012-09-27 12:55 ` checked in: " Joel Brobecker
2012-09-20 16:44 ` [PATCH 4/4] Delete unused functions in sol-thread.c Joel Brobecker
2012-09-20 17:31 ` Pedro Alves
2012-09-20 21:43 ` Joel Brobecker
2012-09-20 22:25 ` Joel Brobecker
2012-09-20 22:25 ` Joel Brobecker
2012-09-24 16:27 ` Pedro Alves
2012-09-24 16:37 ` Joel Brobecker
2012-09-27 13:02 ` checked in: New unit sparc-sol-thread.c extracted from sol-thread.c Joel Brobecker
2012-09-24 16:18 ` Pedro Alves [this message]
2012-09-24 16:40 ` [PATCH 4/4] Delete unused functions in sol-thread.c Joel Brobecker
2012-09-27 13:04 ` checked in: sol-thread.c: Remove commented-out code Joel Brobecker
2012-09-27 12:59 ` checked in: [PATCH 4/4] Delete unused functions in sol-thread.c Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506087DE.5090900@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox