From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4] Delete unused functions in sol-thread.c.
Date: Mon, 24 Sep 2012 16:37:00 -0000 [thread overview]
Message-ID: <20120924163656.GG4146@adacore.com> (raw)
In-Reply-To: <506089C4.6040407@redhat.com>
> Fine with me either way.
OK - I will fix the formatting issue, and commit separately.
> > gdb/ChangeLog:
> >
> > * sol-thread.c (ps_lgetxregsize, ps_lgetxregs, ps_lsetxregs):
> > Move these functions to sol-sparc-thread.c.
> > * sol-sparc-thread.c: New file.
>
> Following gdb naming de facto convention this new file would be named
> sparc-sol-thread.c though (as e.g., amd64-linux-nat.c, etc.).
But we already have ravenscar-sparc-thread.c :). I guess we should fix
that too. Global consistency is probably better than per-topic
consistency...
Thanks for the review. I'll work on the last few details as soon as
I have a moment.
--
Joel
next prev parent reply other threads:[~2012-09-24 16:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 16:34 Various build-related fixes for solaris Joel Brobecker
2012-09-20 16:34 ` [PATCH 2/4] Make procfs.c:proc_get_LDT_entry static Joel Brobecker
2012-09-27 12:55 ` checked in: " Joel Brobecker
2012-09-20 16:34 ` [PATCH 1/4] Fix declaration of proc_find_memory_regions Joel Brobecker
2012-09-27 12:55 ` checked in: " Joel Brobecker
2012-09-20 16:34 ` [PATCH 3/4] Add procfs_find_LDT_entry declaration (procfs.h) Joel Brobecker
2012-09-22 14:22 ` Jan Kratochvil
2012-09-27 12:56 ` checked in: " Joel Brobecker
2012-09-20 16:44 ` [PATCH 4/4] Delete unused functions in sol-thread.c Joel Brobecker
2012-09-20 17:31 ` Pedro Alves
2012-09-20 21:43 ` Joel Brobecker
2012-09-20 22:25 ` Joel Brobecker
2012-09-20 22:25 ` Joel Brobecker
2012-09-24 16:27 ` Pedro Alves
2012-09-24 16:37 ` Joel Brobecker [this message]
2012-09-27 13:02 ` checked in: New unit sparc-sol-thread.c extracted from sol-thread.c Joel Brobecker
2012-09-24 16:18 ` [PATCH 4/4] Delete unused functions in sol-thread.c Pedro Alves
2012-09-24 16:40 ` Joel Brobecker
2012-09-27 13:04 ` checked in: sol-thread.c: Remove commented-out code Joel Brobecker
2012-09-27 12:59 ` checked in: [PATCH 4/4] Delete unused functions in sol-thread.c Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120924163656.GG4146@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox