From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18940 invoked by alias); 24 Sep 2012 16:37:21 -0000 Received: (qmail 18790 invoked by uid 22791); 24 Sep 2012 16:37:19 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Sep 2012 16:37:05 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 63D641C7A61; Mon, 24 Sep 2012 12:37:04 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id WIDuZDcxVsv2; Mon, 24 Sep 2012 12:37:04 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 35FD61C7A5D; Mon, 24 Sep 2012 12:37:04 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 09DE2CCCE8; Mon, 24 Sep 2012 18:36:56 +0200 (CEST) Date: Mon, 24 Sep 2012 16:37:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/4] Delete unused functions in sol-thread.c. Message-ID: <20120924163656.GG4146@adacore.com> References: <1348158841-2313-1-git-send-email-brobecker@adacore.com> <1348158841-2313-5-git-send-email-brobecker@adacore.com> <505B52EA.5080908@redhat.com> <20120920214340.GB5423@adacore.com> <20120920222447.GC5423@adacore.com> <20120920222534.GA28592@adacore.com> <506089C4.6040407@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <506089C4.6040407@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00515.txt.bz2 > Fine with me either way. OK - I will fix the formatting issue, and commit separately. > > gdb/ChangeLog: > > > > * sol-thread.c (ps_lgetxregsize, ps_lgetxregs, ps_lsetxregs): > > Move these functions to sol-sparc-thread.c. > > * sol-sparc-thread.c: New file. > > Following gdb naming de facto convention this new file would be named > sparc-sol-thread.c though (as e.g., amd64-linux-nat.c, etc.). But we already have ravenscar-sparc-thread.c :). I guess we should fix that too. Global consistency is probably better than per-topic consistency... Thanks for the review. I'll work on the last few details as soon as I have a moment. -- Joel