From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18728 invoked by alias); 24 Sep 2012 16:18:55 -0000 Received: (qmail 18718 invoked by uid 22791); 24 Sep 2012 16:18:54 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Sep 2012 16:18:41 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8OGIdtY009521 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 24 Sep 2012 12:18:39 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8OGIcag030536; Mon, 24 Sep 2012 12:18:38 -0400 Message-ID: <506087DE.5090900@redhat.com> Date: Mon, 24 Sep 2012 16:18:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [PATCH 4/4] Delete unused functions in sol-thread.c. References: <1348158841-2313-1-git-send-email-brobecker@adacore.com> <1348158841-2313-5-git-send-email-brobecker@adacore.com> <505B52EA.5080908@redhat.com> <20120920214340.GB5423@adacore.com> In-Reply-To: <20120920214340.GB5423@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00513.txt.bz2 On 09/20/2012 10:43 PM, Joel Brobecker wrote: > gdb/ChangeLog: > > * sol-thread.c (ps_lgetxregsize, ps_lgetxregs, ps_lsetxregs): > Enable this code for sparc hosts only. Looks good to me, with > +#if defined(__sparc) || defined(__sparcv9) space before parens. > gdb/ChangeLog: > > * sol-thread.c (ps_lgetxregsize, ps_lgetxregs, ps_lsetxregs): > Remove commented-out code. There's more '#if 0'-related code in the file. I think that if we're removing these, we should get rid of all of it. I found it curious that http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/lib/libc_db/common/thread_db.c says "Currently unused by dbx"... -- Pedro Alves