Re: [Bug win32/14529] Make gdb capable of JIT-debugging on W32

[LRN <lrn1986@gmail.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11.09.2012 22:27, Pedro Alves wrote:
> On 09/11/2012 07:23 PM, LRN wrote: On 11.09.2012 22:08, Pedro Alves
> wrote:
>>>> On 08/31/2012 04:37 PM, LRN wrote:
>>>>>>>>> @@ -1055,6 +1065,7 @@ Options:\n\n\ --dbx DBX
>>>>>>>>> compatibility mode.\n\ --directory=DIR    Search
>>>>>>>>> for source files in DIR.\n\ --epoch
>>>>>>>>> Output information used by epoch emacs-GDB
>>>>>>>>> interface.\n\ + --event=EVENT      Signal the EVENT
>>>>>>>>> when attached to a process. W32 only.\n\
>>>>>>> 
>>>>>>> And also this part.
>>>>> They were, initially. However, gdb contribution
>>>>> documentation said that gdb devs frown upon extra #ifdefs
>>>>> in files that are not platform-specific. The code is mostly
>>>>> platform independent, it's the two W32API functions that
>>>>> only work on W32 (and you can write non-W32 equivalent, if
>>>>> you figure out how to make it work). Thus, i removed extra
>>>>> #ifdefs in main.c and other files.
>>>> 
>>>> Please consider also cross builds.  IOW, a gdb hosted on
>>>> Windows, but that is built to target something else.  In that
>>>> case, as is, you will end up with the option compiled in.
>>>> But if you remove any mention that this is for Windows only,
>>>> it'll be confusing.
> OK, that means moving configure.ac patches from $host_os case 
> to...where? Should i just make a new case "${target}" in 
> *cygwin*|*mingw*) default_w32_jitdbg=1 ;; esac somewhere? Is it
> ${target}, or ${target_os}? What if there are multiple targets
> (i've seen something like that in configure.ac)?
> 
>> Right, that's the issue -- you can't just check the target,
>> because there might be more than one.  So the option should be
>> clear at what it does, and where it applies.
How do i make it clear? By renaming it? Removing the code that enables
it by default?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (MingW32)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQEcBAEBAgAGBQJQT4NcAAoJEOs4Jb6SI2CwC1AH/2BGTYrXSwl0F6Ij3sRSzu5a
M5I4jMHIYc+EaUdTibTNQP4Pw2yXSmOAf0ass3ZL8VNrvyl/Gz4mXRk8EvSoEI11
tT6MwUNcrHk2TBuz7h/yl1HN/fvp9sm5p1ahgwV8WCyladtk8X61AmhOrxLA/wha
+JlWbM+VLL6Wk4ZTpEBPSlUEIL2kxQFP7yGZ1O2QKRZ/EDcKcpXnMhpQNrBOMEfz
/oAmF94iyn+KdqEy5oDNVN8c87jBlUMxi0U970FxIBIuEmx6UJekcPWf37Ada1Ba
HxOmxQvGSF5sBvgyCMWUWsqg5pxtHLLp/8s/PQAlP/iDTeWxeoiXVz+Sqa/d4Nc=
=2r+9
-----END PGP SIGNATURE-----