From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10110 invoked by alias); 11 Sep 2012 18:31:22 -0000 Received: (qmail 9960 invoked by uid 22791); 11 Sep 2012 18:31:18 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KHOP_PGP_INLINE,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_DB X-Spam-Check-By: sourceware.org Received: from mail-lb0-f169.google.com (HELO mail-lb0-f169.google.com) (209.85.217.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Sep 2012 18:31:00 +0000 Received: by lbon3 with SMTP id n3so642614lbo.0 for ; Tue, 11 Sep 2012 11:30:58 -0700 (PDT) Received: by 10.152.135.147 with SMTP id ps19mr16770984lab.52.1347388258817; Tue, 11 Sep 2012 11:30:58 -0700 (PDT) Received: from [192.168.4.39] (broadband-95-84-200-156.nationalcablenetworks.ru. [95.84.200.156]) by mx.google.com with ESMTPS id c6sm3768237lbk.10.2012.09.11.11.30.57 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 11 Sep 2012 11:30:58 -0700 (PDT) Message-ID: <504F835E.2000100@gmail.com> Date: Tue, 11 Sep 2012 18:31:00 -0000 From: LRN User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Thunderbird/18.0a1 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [Bug win32/14529] Make gdb capable of JIT-debugging on W32 References: <503E575D.1000608@gmail.com> <83y5kvp0za.fsf@gnu.org> <5040DA38.2070802@gmail.com> <504F7E31.10306@redhat.com> <504F818B.6090104@gmail.com> <504F8297.5090507@redhat.com> In-Reply-To: <504F8297.5090507@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00172.txt.bz2 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11.09.2012 22:27, Pedro Alves wrote: > On 09/11/2012 07:23 PM, LRN wrote: On 11.09.2012 22:08, Pedro Alves > wrote: >>>> On 08/31/2012 04:37 PM, LRN wrote: >>>>>>>>> @@ -1055,6 +1065,7 @@ Options:\n\n\ --dbx DBX >>>>>>>>> compatibility mode.\n\ --directory=DIR Search >>>>>>>>> for source files in DIR.\n\ --epoch >>>>>>>>> Output information used by epoch emacs-GDB >>>>>>>>> interface.\n\ + --event=EVENT Signal the EVENT >>>>>>>>> when attached to a process. W32 only.\n\ >>>>>>> >>>>>>> And also this part. >>>>> They were, initially. However, gdb contribution >>>>> documentation said that gdb devs frown upon extra #ifdefs >>>>> in files that are not platform-specific. The code is mostly >>>>> platform independent, it's the two W32API functions that >>>>> only work on W32 (and you can write non-W32 equivalent, if >>>>> you figure out how to make it work). Thus, i removed extra >>>>> #ifdefs in main.c and other files. >>>> >>>> Please consider also cross builds. IOW, a gdb hosted on >>>> Windows, but that is built to target something else. In that >>>> case, as is, you will end up with the option compiled in. >>>> But if you remove any mention that this is for Windows only, >>>> it'll be confusing. > OK, that means moving configure.ac patches from $host_os case > to...where? Should i just make a new case "${target}" in > *cygwin*|*mingw*) default_w32_jitdbg=1 ;; esac somewhere? Is it > ${target}, or ${target_os}? What if there are multiple targets > (i've seen something like that in configure.ac)? > >> Right, that's the issue -- you can't just check the target, >> because there might be more than one. So the option should be >> clear at what it does, and where it applies. How do i make it clear? By renaming it? Removing the code that enables it by default? -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (MingW32) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBAgAGBQJQT4NcAAoJEOs4Jb6SI2CwC1AH/2BGTYrXSwl0F6Ij3sRSzu5a M5I4jMHIYc+EaUdTibTNQP4Pw2yXSmOAf0ass3ZL8VNrvyl/Gz4mXRk8EvSoEI11 tT6MwUNcrHk2TBuz7h/yl1HN/fvp9sm5p1ahgwV8WCyladtk8X61AmhOrxLA/wha +JlWbM+VLL6Wk4ZTpEBPSlUEIL2kxQFP7yGZ1O2QKRZ/EDcKcpXnMhpQNrBOMEfz /oAmF94iyn+KdqEy5oDNVN8c87jBlUMxi0U970FxIBIuEmx6UJekcPWf37Ada1Ba HxOmxQvGSF5sBvgyCMWUWsqg5pxtHLLp/8s/PQAlP/iDTeWxeoiXVz+Sqa/d4Nc= =2r+9 -----END PGP SIGNATURE-----