Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Anton Kolesov <Anton.Kolesov@synopsys.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: Francois Bedard <Francois.Bedard@synopsys.com>
Subject: Re: [PATCH 5/5 v2] arc: Add prologue analysis
Date: Tue, 28 Mar 2017 13:28:00 -0000	[thread overview]
Message-ID: <50152eaa-1b56-6a1b-b579-58cd0e01b966@redhat.com> (raw)
In-Reply-To: <39A54937CC95F24AA2F794E2D2B66B13586EA2B6@DE02WEMBXB.internal.synopsys.com>

On 03/27/2017 03:20 PM, Anton Kolesov wrote:
>> -----Original Message-----
>> From: Anton Kolesov [mailto:Anton.Kolesov@synopsys.com]
>> Sent: Wednesday, March 15, 2017 18:18
>> To: gdb-patches@sourceware.org
>> Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>; Francois Bedard
>> <Francois.Bedard@synopsys.com>
>> Subject: [PATCH 5/5 v2] arc: Add prologue analysis
>>
>> Changes in v2:
>>
>>   * Use "prepare_for" in test cases.
>>   * Ensure that all test cases have unique names in gdb.sum.
>>   * Fix invalid indentation in test cases.
> 
> Hi Pedro,
> 
> Any feedback on two v2 patches from this patch series? 

v2 only included patches 4 and 5, right?

If so, other than the nits I sent in the reply to patch #4 v2,
I have no further comments.  Fix those and you're good to go.

Thanks,
Pedro Alves


  reply	other threads:[~2017-03-28 13:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 10:01 [PATCH 1/5] arc: Align internal regnums with architectural regnums Anton Kolesov
2017-02-14 10:01 ` [PATCH 3/5] arc: Add "maintenance print arc" command prefix Anton Kolesov
2017-02-17 13:02   ` Pedro Alves
2017-02-14 10:01 ` [PATCH 5/5] arc: Add prologue analysis Anton Kolesov
2017-02-14 15:51   ` Eli Zaretskii
2017-02-17 13:25   ` Pedro Alves
2017-03-15 15:18     ` [PATCH 5/5 v2] " Anton Kolesov
2017-03-15 15:59       ` Eli Zaretskii
2017-03-27 14:20       ` Anton Kolesov
2017-03-28 13:28         ` Pedro Alves [this message]
2017-02-14 10:01 ` [PATCH 4/5] arc: Add disassembler helper Anton Kolesov
2017-02-14 15:50   ` Eli Zaretskii
2017-02-17 13:00   ` Pedro Alves
2017-02-17 13:01   ` Pedro Alves
2017-02-14 10:01 ` [PATCH 2/5] arc: Set section to ".text" when disassembling Anton Kolesov
2017-02-15 22:27   ` Yao Qi
2017-02-16 16:35     ` Anton Kolesov
2017-02-17 12:31       ` Pedro Alves
2017-03-15 15:16         ` Anton Kolesov
2017-02-17 13:26 ` [PATCH 1/5] arc: Align internal regnums with architectural regnums Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50152eaa-1b56-6a1b-b579-58cd0e01b966@redhat.com \
    --to=palves@redhat.com \
    --cc=Anton.Kolesov@synopsys.com \
    --cc=Francois.Bedard@synopsys.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox