Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Anton Kolesov <Anton.Kolesov@synopsys.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	Francois Bedard	<Francois.Bedard@synopsys.com>
Subject: RE: [PATCH 2/5] arc: Set section to ".text" when disassembling
Date: Thu, 16 Feb 2017 16:35:00 -0000	[thread overview]
Message-ID: <39A54937CC95F24AA2F794E2D2B66B1358249A97@DE02WEMBXB.internal.synopsys.com> (raw)
In-Reply-To: <CAH=s-POacRUV_BBWMxt4hT0ohAO7w182tpt6AWRgaFNgU0Ru2g@mail.gmail.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 630 bytes --]

Hi Yao,

> info->section should be valid, but why must it be ".text"?  Can I
> info->disassembly
> instructions in .plt section?  How about using find_pc_section (addr) to get
> the right section?  like mep_gdb_print_insn.

Actual section doesn't matter here because opcodes really need elf header, which is
just obtained through a section. I've used .text simply because it is the section that is
very likely to exist. Using find_pc_section seems to be a much better solution, I wasn't
aware of it. Will change this in second version of the patch.

Anton

> 
> --
> Yao (齐尧)
\x16º&Öéj×!zÊÞ¶êç×~ôëÙb²Ö«r\x18\x1dn–­r\x17¬

  reply	other threads:[~2017-02-16 16:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 10:01 [PATCH 1/5] arc: Align internal regnums with architectural regnums Anton Kolesov
2017-02-14 10:01 ` [PATCH 5/5] arc: Add prologue analysis Anton Kolesov
2017-02-14 15:51   ` Eli Zaretskii
2017-02-17 13:25   ` Pedro Alves
2017-03-15 15:18     ` [PATCH 5/5 v2] " Anton Kolesov
2017-03-15 15:59       ` Eli Zaretskii
2017-03-27 14:20       ` Anton Kolesov
2017-03-28 13:28         ` Pedro Alves
2017-02-14 10:01 ` [PATCH 4/5] arc: Add disassembler helper Anton Kolesov
2017-02-14 15:50   ` Eli Zaretskii
2017-02-17 13:00   ` Pedro Alves
2017-02-17 13:01   ` Pedro Alves
2017-02-14 10:01 ` [PATCH 2/5] arc: Set section to ".text" when disassembling Anton Kolesov
2017-02-15 22:27   ` Yao Qi
2017-02-16 16:35     ` Anton Kolesov [this message]
2017-02-17 12:31       ` Pedro Alves
2017-03-15 15:16         ` Anton Kolesov
2017-02-14 10:01 ` [PATCH 3/5] arc: Add "maintenance print arc" command prefix Anton Kolesov
2017-02-17 13:02   ` Pedro Alves
2017-02-17 13:26 ` [PATCH 1/5] arc: Align internal regnums with architectural regnums Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39A54937CC95F24AA2F794E2D2B66B1358249A97@DE02WEMBXB.internal.synopsys.com \
    --to=anton.kolesov@synopsys.com \
    --cc=Francois.Bedard@synopsys.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox