From: Anton Kolesov <Anton.Kolesov@synopsys.com>
To: gdb-patches@sourceware.org
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>,
Francois Bedard <Francois.Bedard@synopsys.com>
Subject: [PATCH 2/5] arc: Set section to ".text" when disassembling
Date: Tue, 14 Feb 2017 10:01:00 -0000 [thread overview]
Message-ID: <20170214100130.29194-2-Anton.Kolesov@synopsys.com> (raw)
In-Reply-To: <20170214100130.29194-1-Anton.Kolesov@synopsys.com>
ARC disassembler requires that disassemble_info->section is valid - it will be
used to access program headers of ELF files that is needed to distinguish
between ARC EM and HS (ARC600, ARC700 and ARC v2 can be distinguished by BFD's
`mach` attribute). Without this information disassembler will default to ARC
EM for ARC v2 targets, and it will not recognize instructions specific to ARC
HS, for example, double-word store and load.
gdb/ChangeLog:
yyyy-mm-dd Anton Kolesov <anton.kolesov@synopsys.com>
* arc-tdep.c (arc_delayed_print_insn): Set info->section.
---
gdb/arc-tdep.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/gdb/arc-tdep.c b/gdb/arc-tdep.c
index f78e3a9..e4b2e7a 100644
--- a/gdb/arc-tdep.c
+++ b/gdb/arc-tdep.c
@@ -705,6 +705,16 @@ arc_delayed_print_insn (bfd_vma addr, struct disassemble_info *info)
will handle NULL value gracefully. */
print_insn = arc_get_disassembler (exec_bfd);
gdb_assert (print_insn != NULL);
+
+ /* ARC disassembler requires that info->section is valid - it will be used to
+ access program headers of ELF files that is needed to distinguish between
+ ARC EM and HS (ARC600, ARC700 and ARC v2 can be distinguished by BFD's
+ `mach` attribute). Without this information disassembler will default to
+ ARC EM for ARC v2 targets, and it will not recognize instructions specific
+ to ARC HS, for example, double-word store and load. */
+ if (exec_bfd != NULL)
+ info->section = bfd_get_section_by_name (exec_bfd, ".text");
+
return print_insn (addr, info);
}
--
2.8.3
next prev parent reply other threads:[~2017-02-14 10:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 10:01 [PATCH 1/5] arc: Align internal regnums with architectural regnums Anton Kolesov
2017-02-14 10:01 ` [PATCH 3/5] arc: Add "maintenance print arc" command prefix Anton Kolesov
2017-02-17 13:02 ` Pedro Alves
2017-02-14 10:01 ` [PATCH 4/5] arc: Add disassembler helper Anton Kolesov
2017-02-14 15:50 ` Eli Zaretskii
2017-02-17 13:00 ` Pedro Alves
2017-02-17 13:01 ` Pedro Alves
2017-02-14 10:01 ` [PATCH 5/5] arc: Add prologue analysis Anton Kolesov
2017-02-14 15:51 ` Eli Zaretskii
2017-02-17 13:25 ` Pedro Alves
2017-03-15 15:18 ` [PATCH 5/5 v2] " Anton Kolesov
2017-03-15 15:59 ` Eli Zaretskii
2017-03-27 14:20 ` Anton Kolesov
2017-03-28 13:28 ` Pedro Alves
2017-02-14 10:01 ` Anton Kolesov [this message]
2017-02-15 22:27 ` [PATCH 2/5] arc: Set section to ".text" when disassembling Yao Qi
2017-02-16 16:35 ` Anton Kolesov
2017-02-17 12:31 ` Pedro Alves
2017-03-15 15:16 ` Anton Kolesov
2017-02-17 13:26 ` [PATCH 1/5] arc: Align internal regnums with architectural regnums Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214100130.29194-2-Anton.Kolesov@synopsys.com \
--to=anton.kolesov@synopsys.com \
--cc=Francois.Bedard@synopsys.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox