Re: [PATCH] gdb, gdbserver: remove WinCE support code

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-04-12 11:12 a.m., Simon Marchi via Gdb-patches wrote:
> On 2021-04-12 7:42 a.m., Pedro Alves wrote:
>> On 11/04/21 00:10, Simon Marchi via Gdb-patches wrote:
>>> The support for WinCE was removed with commit 84b300de3666 ("gdbserver:
>>> remove support for ARM/WinCE").  There is some leftover code for WinCE
>>> support, guarded by the _WIN32_WCE macro, which I didn't know of at the
>>> time.
>>>
>>> I didn't remove the _WIN32_WCE references in the tests, because in
>>> theory we still support the WinCE architecture in GDB (when debugging
>>> remotely).  So someone could run a test with that (although I'd be
>>> really surprised).
>>>
>>> gdb/ChangeLog:
>>>
>>> 	* nat/windows-nat.c: Remove all code guarded by _WIN32_WCE.
>>> 	* nat/windows-nat.h: Likewise.
>>>
>>> gdbserver/ChangeLog:
>>>
>>> 	* win32-low.cc: Remove all code guarded by _WIN32_WCE.
>>> 	* win32-low.h: Likewise.
>>
>> OK.
>>
>> We can also get rid of the whole 
>>
>>   the_target->hostio_last_error / hostio-errno.cc / hostio_last_error_from_errno
>>
>> abstraction now.
> 
> Ok, I didn't really know what that was for.  I pushed the patch and will
> send a follow up for that.
> 
> Simon

Well, I spoke too soon, I don't really understand what abstraction you
are talking about.

Simon