Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb, gdbserver: remove WinCE support code
Date: Tue, 13 Apr 2021 13:29:07 -0600	[thread overview]
Message-ID: <874kgahtks.fsf@tromey.com> (raw)
In-Reply-To: <20210410231021.1232451-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Sat, 10 Apr 2021 19:10:21 -0400")

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> The support for WinCE was removed with commit 84b300de3666 ("gdbserver:
Simon> remove support for ARM/WinCE").  There is some leftover code for WinCE
Simon> support, guarded by the _WIN32_WCE macro, which I didn't know of at the
Simon> time.

I found one more spot, let me know what you think of the appended.

Tom

commit 765c5c546656b1a8012cf78d75aab644451d6d3e
Author: Tom Tromey <tromey@adacore.com>
Date:   Tue Apr 13 13:25:53 2021 -0600

    Remove use of _WIN32_WCE
    
    This removes the one last use of _WIN32_WCE from gdbserver.
    
    gdbserver/ChangeLog
    2021-04-13  Tom Tromey  <tromey@adacore.com>
    
            * win32-low.cc (windows_nat::handle_load_dll): Don't check
            _WIN32_WCE.

diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog
index ff008151421..e85fa775d7a 100644
--- a/gdbserver/ChangeLog
+++ b/gdbserver/ChangeLog
@@ -1,3 +1,8 @@
+2021-04-13  Tom Tromey  <tromey@adacore.com>
+
+	* win32-low.cc (windows_nat::handle_load_dll): Don't check
+	_WIN32_WCE.
+
 2021-04-13  Tom Tromey  <tromey@adacore.com>
 
 	* win32-low.cc (winapi_CreateToolhelp32Snapshot)
diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc
index 6502d857732..39a6848307a 100644
--- a/gdbserver/win32-low.cc
+++ b/gdbserver/win32-low.cc
@@ -1221,11 +1221,9 @@ windows_nat::handle_load_dll ()
 
   dll_name = get_image_name (current_process_handle,
 			     event->lpImageName, event->fUnicode);
-#ifndef _WIN32_WCE
   if (dll_name == nullptr
       && event->lpBaseOfDll != nullptr)
     dll_name = win32_add_dll (event->lpBaseOfDll);
-#endif
   if (dll_name == nullptr)
     return;
 

  parent reply	other threads:[~2021-04-13 19:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-10 23:10 Simon Marchi via Gdb-patches
2021-04-12 11:42 ` Pedro Alves
2021-04-12 15:12   ` Simon Marchi via Gdb-patches
2021-04-12 15:24     ` Simon Marchi via Gdb-patches
2021-04-12 22:20       ` [PATCH] Remove process_stratum_target::hostio_last_error abstraction (Re: [PATCH] gdb, gdbserver: remove WinCE support code) Pedro Alves
2021-04-12 22:52         ` Pedro Alves
2021-04-12 23:56         ` Simon Marchi via Gdb-patches
2021-04-13 13:12           ` Pedro Alves
2021-04-12 13:57 ` [PATCH] gdb, gdbserver: remove WinCE support code Luis Machado via Gdb-patches
2021-04-12 14:01   ` Simon Marchi via Gdb-patches
2021-04-12 14:07     ` Luis Machado via Gdb-patches
2021-04-13 19:29 ` Tom Tromey [this message]
2021-04-13 21:14   ` Pedro Alves
2021-04-13 21:20     ` [pushed] Remove WinCE code from gdbreplay Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kgahtks.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox