From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cZNqCRxmdGDoFgAAWB0awg (envelope-from ) for ; Mon, 12 Apr 2021 11:24:12 -0400 Received: by simark.ca (Postfix, from userid 112) id 185381F104; Mon, 12 Apr 2021 11:24:12 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1436F1E789 for ; Mon, 12 Apr 2021 11:24:11 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 40419385781A; Mon, 12 Apr 2021 15:24:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 40419385781A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1618241050; bh=0QVe1hq83P30N+eeMx8ivlU65tIgAtvUyQaLUwwE968=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=eD1XvMYvs2MlBHS3TyoubqIB6uyACAr5Svys5BMEb5TIWn+wiOnQwj5PRqUQl4t0h O++oQdkVIh0IgYpa8S/VOEPRLGQY6atsuqMJcXEusy03N3S+UdUd8YDdXN8kTAIpX6 7PSHW4VeGo4yviduIxwr2/RHs6m1mgLZR2Y6QNRM= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id A556B385781A for ; Mon, 12 Apr 2021 15:24:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A556B385781A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13CFO0r7001509 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Apr 2021 11:24:05 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13CFO0r7001509 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C8A4B1E789; Mon, 12 Apr 2021 11:24:00 -0400 (EDT) Subject: Re: [PATCH] gdb, gdbserver: remove WinCE support code To: Pedro Alves , gdb-patches@sourceware.org References: <20210410231021.1232451-1-simon.marchi@polymtl.ca> <563cec09-990a-77f4-042f-2b95215e9829@palves.net> <1dd71397-369c-b88f-832d-b6c525e5bee8@polymtl.ca> Message-ID: <4e6132b6-acd0-0c9d-fdee-d693784efe13@polymtl.ca> Date: Mon, 12 Apr 2021 11:24:00 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1dd71397-369c-b88f-832d-b6c525e5bee8@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 12 Apr 2021 15:24:00 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-04-12 11:12 a.m., Simon Marchi via Gdb-patches wrote: > On 2021-04-12 7:42 a.m., Pedro Alves wrote: >> On 11/04/21 00:10, Simon Marchi via Gdb-patches wrote: >>> The support for WinCE was removed with commit 84b300de3666 ("gdbserver: >>> remove support for ARM/WinCE"). There is some leftover code for WinCE >>> support, guarded by the _WIN32_WCE macro, which I didn't know of at the >>> time. >>> >>> I didn't remove the _WIN32_WCE references in the tests, because in >>> theory we still support the WinCE architecture in GDB (when debugging >>> remotely). So someone could run a test with that (although I'd be >>> really surprised). >>> >>> gdb/ChangeLog: >>> >>> * nat/windows-nat.c: Remove all code guarded by _WIN32_WCE. >>> * nat/windows-nat.h: Likewise. >>> >>> gdbserver/ChangeLog: >>> >>> * win32-low.cc: Remove all code guarded by _WIN32_WCE. >>> * win32-low.h: Likewise. >> >> OK. >> >> We can also get rid of the whole >> >> the_target->hostio_last_error / hostio-errno.cc / hostio_last_error_from_errno >> >> abstraction now. > > Ok, I didn't really know what that was for. I pushed the patch and will > send a follow up for that. > > Simon Well, I spoke too soon, I don't really understand what abstraction you are talking about. Simon