From: Pedro Alves <palves@redhat.com>
To: Luis Machado <lgustavo@codesourcery.com>,
Michael Sturm <michael.sturm@intel.com>,
mark.kettenis@xs4all.nl, eliz@gnu.org
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 5/5] Add support for Intel PKRU register to GDB and GDBserver.
Date: Fri, 09 Dec 2016 17:16:00 -0000 [thread overview]
Message-ID: <4d5f3401-de26-ea46-740c-516e237a7305@redhat.com> (raw)
In-Reply-To: <a750534f-86b3-4648-ab85-82c06de23e6c@codesourcery.com>
On 12/02/2016 01:59 AM, Luis Machado wrote:
>> +set comp_flags "-I${srcdir}/../nat/"
>> +
>> +if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} \
>> + [list debug additional_flags=${comp_flags}]] } {
>
> Add 'untested "failed to compile"'
Nope, that's already handled by prepare_for_testing itself.
The test message used is the first argument to prepare_for_testing
above. Unfortunately, many tests blindly pass "${testfile}.exp"...
From build_executable_from_specs (called by prepare_for_testing):
[....]
# TESTNAME is the name of the test; this is passed to 'untested' if
# something fails.
[....]
I had started using:
prepare_for_testing "failed to prepare" ....
a while ago. See:
grep "prepare_for_testing \"[A-Za-z0-9_ ]\+" -rn
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-12-09 17:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 13:39 [PATCH v2 0/5] Add support for PKRU register to GDB and GDBServer Michael Sturm
2016-12-01 13:39 ` [PATCH v2 4/5] Add target description for avx-avx512 Michael Sturm
2016-12-01 13:39 ` [PATCH v2 5/5] Add support for Intel PKRU register to GDB and GDBserver Michael Sturm
2016-12-01 17:35 ` Eli Zaretskii
2016-12-02 2:00 ` Luis Machado
2016-12-06 10:54 ` Sturm, Michael
2016-12-09 17:16 ` Pedro Alves [this message]
2016-12-19 9:17 ` Sturm, Michael
2016-12-01 13:39 ` [PATCH v2 2/5] Change xstate_bv handling to use 8 bytes of data Michael Sturm
2016-12-02 1:26 ` Luis Machado
2016-12-05 13:52 ` Sturm, Michael
2016-12-01 13:39 ` [PATCH v2 3/5] Rename target descriptions to reflect actual content of description Michael Sturm
2016-12-01 13:39 ` [PATCH v2 1/5] Sync up x86-gcc-cpuid.h with cpuid.h from gcc-6 branch Michael Sturm
2016-12-02 1:17 ` Luis Machado
2016-12-05 13:42 ` Sturm, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d5f3401-de26-ea46-740c-516e237a7305@redhat.com \
--to=palves@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=mark.kettenis@xs4all.nl \
--cc=michael.sturm@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox