From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21990 invoked by alias); 9 Dec 2016 17:16:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21965 invoked by uid 89); 9 Dec 2016 17:16:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=nope, sk:build_e, Hx-languages-length:858, H*M:740c X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Dec 2016 17:15:59 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 46B5C338860; Fri, 9 Dec 2016 17:15:58 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB9HFskh000937; Fri, 9 Dec 2016 12:15:55 -0500 Subject: Re: [PATCH v2 5/5] Add support for Intel PKRU register to GDB and GDBserver. To: Luis Machado , Michael Sturm , mark.kettenis@xs4all.nl, eliz@gnu.org References: <1480599538-30543-1-git-send-email-michael.sturm@intel.com> <1480599538-30543-6-git-send-email-michael.sturm@intel.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <4d5f3401-de26-ea46-740c-516e237a7305@redhat.com> Date: Fri, 09 Dec 2016 17:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-12/txt/msg00252.txt.bz2 On 12/02/2016 01:59 AM, Luis Machado wrote: >> +set comp_flags "-I${srcdir}/../nat/" >> + >> +if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} \ >> + [list debug additional_flags=${comp_flags}]] } { > > Add 'untested "failed to compile"' Nope, that's already handled by prepare_for_testing itself. The test message used is the first argument to prepare_for_testing above. Unfortunately, many tests blindly pass "${testfile}.exp"... >From build_executable_from_specs (called by prepare_for_testing): [....] # TESTNAME is the name of the test; this is passed to 'untested' if # something fails. [....] I had started using: prepare_for_testing "failed to prepare" .... a while ago. See: grep "prepare_for_testing \"[A-Za-z0-9_ ]\+" -rn Thanks, Pedro Alves