From: Pedro Alves <palves@redhat.com>
To: Jeff Kenton <jkenton@tilera.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add support for Tilera TILE-Gx processor (part 3/3: gdbserver)
Date: Fri, 25 May 2012 18:18:00 -0000 [thread overview]
Message-ID: <4FBFCCF8.10306@redhat.com> (raw)
In-Reply-To: <4FBE8C6D.3070208@tilera.com>
On 05/24/2012 08:30 PM, Jeff Kenton wrote:
> diff -r -u -N /home/packages/gdb-7.4x/gdb/gdbserver/linux-tile-low.c ./gdb/gdbserver/linux-tile-low.c
> --- /home/packages/gdb-7.4x/gdb/gdbserver/linux-tile-low.c 1969-12-31 19:00:00.000000000 -0500
> +++ ./gdb/gdbserver/linux-tile-low.c 2012-05-24 13:43:30.025286000 -0400
> @@ -0,0 +1,164 @@
> +
> +
Two spurious empty lines here. Please remove them.
> +/* GNU/Linux/TILE-Gx specific low level interface, GDBserver.
> --- /home/packages/gdb-7.4x/gdb/gdbserver/linux-tile-low.c 1969-12-31 19:00:00.000000000 -0500
> +++ ./gdb/gdbserver/linux-tile-low.c 2012-05-24 13:43:30.025286000 -0400
> +#include "gdb_proc_service.h"
...
> +linux-tile-low.o: linux-tile-low.c $(linux_low_h) $(server_h)
This now needs to depend on $(gdb_proc_service_h) too.
Otherwise looks fine.
--
Pedro Alves
next prev parent reply other threads:[~2012-05-25 18:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 16:20 Jeff Kenton
2012-05-21 14:29 ` Jeff Kenton
2012-05-23 17:50 ` Pedro Alves
2012-05-24 11:59 ` Jeff Kenton
2012-05-24 12:05 ` Pedro Alves
2012-05-24 19:31 ` Jeff Kenton
2012-05-25 18:18 ` Pedro Alves [this message]
2012-05-29 15:28 ` Jeff Kenton
2012-05-30 20:06 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBFCCF8.10306@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jkenton@tilera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox