From: Pedro Alves <palves@redhat.com>
To: Jeff Kenton <jkenton@tilera.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add support for Tilera TILE-Gx processor (part 3/3: gdbserver)
Date: Thu, 24 May 2012 12:05:00 -0000 [thread overview]
Message-ID: <4FBE23D5.8080400@redhat.com> (raw)
In-Reply-To: <4FBE22AD.4070204@tilera.com>
On 05/24/2012 12:59 PM, Jeff Kenton wrote:
> On 05/23/2012 01:49 PM, Pedro Alves wrote:
>> On 05/21/2012 03:29 PM, Jeff Kenton wrote:
>>> * Makefile.in: Add tilegx dependencies.
>>> * configure.srv: Add tilegx dependencies.
>>> * linux-tile-low.c: New file.
>> This needs to be more specific. Something like:
>>
>> * Makefile.in (SFILES): Add linux-tile-low.c.
>> (linux-tile-low.o, reg-tilegx.o, reg-tilegx.c): New rules.
>> * configure.srv: Handle tilegx-*-linux*.
>> * linux-tile-low.c: New file.
>>
>>
>> Otherwise looks fine, thanks.
>>
>> Same comment about ps_get_thread_area though.
>>
>
> Pedro,
>
> How is this different from your comment about ps_get_thread_area in your response to part 2?
Not sure what you mean. It's the same comment, but applied to gdbserver. If a ps_get_thread_area
function should be added to gdb/tilegx-linux-nat.c, then one should also be added to
gdbserver/linux-tile-low.c.
--
Pedro Alves
next prev parent reply other threads:[~2012-05-24 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 16:20 Jeff Kenton
2012-05-21 14:29 ` Jeff Kenton
2012-05-23 17:50 ` Pedro Alves
2012-05-24 11:59 ` Jeff Kenton
2012-05-24 12:05 ` Pedro Alves [this message]
2012-05-24 19:31 ` Jeff Kenton
2012-05-25 18:18 ` Pedro Alves
2012-05-29 15:28 ` Jeff Kenton
2012-05-30 20:06 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBE23D5.8080400@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jkenton@tilera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox