From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16732 invoked by alias); 24 May 2012 12:05:05 -0000 Received: (qmail 16710 invoked by uid 22791); 24 May 2012 12:05:04 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_EG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 May 2012 12:04:40 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4OC4dqv003091 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 24 May 2012 08:04:39 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4OC4cn0010591; Thu, 24 May 2012 08:04:38 -0400 Message-ID: <4FBE23D5.8080400@redhat.com> Date: Thu, 24 May 2012 12:05:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Jeff Kenton CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Add support for Tilera TILE-Gx processor (part 3/3: gdbserver) References: <4FAD3C4D.9080409@tilera.com> <4FBA5138.4090203@tilera.com> <4FBD2341.2000506@redhat.com> <4FBE22AD.4070204@tilera.com> In-Reply-To: <4FBE22AD.4070204@tilera.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00925.txt.bz2 On 05/24/2012 12:59 PM, Jeff Kenton wrote: > On 05/23/2012 01:49 PM, Pedro Alves wrote: >> On 05/21/2012 03:29 PM, Jeff Kenton wrote: >>> * Makefile.in: Add tilegx dependencies. >>> * configure.srv: Add tilegx dependencies. >>> * linux-tile-low.c: New file. >> This needs to be more specific. Something like: >> >> * Makefile.in (SFILES): Add linux-tile-low.c. >> (linux-tile-low.o, reg-tilegx.o, reg-tilegx.c): New rules. >> * configure.srv: Handle tilegx-*-linux*. >> * linux-tile-low.c: New file. >> >> >> Otherwise looks fine, thanks. >> >> Same comment about ps_get_thread_area though. >> > > Pedro, > > How is this different from your comment about ps_get_thread_area in your response to part 2? Not sure what you mean. It's the same comment, but applied to gdbserver. If a ps_get_thread_area function should be added to gdb/tilegx-linux-nat.c, then one should also be added to gdbserver/linux-tile-low.c. -- Pedro Alves