From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6732 invoked by alias); 25 May 2012 18:18:56 -0000 Received: (qmail 6723 invoked by uid 22791); 25 May 2012 18:18:55 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 May 2012 18:18:39 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4PIIctk022272 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 25 May 2012 14:18:38 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4PIIWnr017009; Fri, 25 May 2012 14:18:38 -0400 Message-ID: <4FBFCCF8.10306@redhat.com> Date: Fri, 25 May 2012 18:18:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Jeff Kenton CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Add support for Tilera TILE-Gx processor (part 3/3: gdbserver) References: <4FAD3C4D.9080409@tilera.com> <4FBA5138.4090203@tilera.com> <4FBD2341.2000506@redhat.com> <4FBE8C6D.3070208@tilera.com> In-Reply-To: <4FBE8C6D.3070208@tilera.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00973.txt.bz2 On 05/24/2012 08:30 PM, Jeff Kenton wrote: > diff -r -u -N /home/packages/gdb-7.4x/gdb/gdbserver/linux-tile-low.c ./gdb/gdbserver/linux-tile-low.c > --- /home/packages/gdb-7.4x/gdb/gdbserver/linux-tile-low.c 1969-12-31 19:00:00.000000000 -0500 > +++ ./gdb/gdbserver/linux-tile-low.c 2012-05-24 13:43:30.025286000 -0400 > @@ -0,0 +1,164 @@ > + > + Two spurious empty lines here. Please remove them. > +/* GNU/Linux/TILE-Gx specific low level interface, GDBserver. > --- /home/packages/gdb-7.4x/gdb/gdbserver/linux-tile-low.c 1969-12-31 19:00:00.000000000 -0500 > +++ ./gdb/gdbserver/linux-tile-low.c 2012-05-24 13:43:30.025286000 -0400 > +#include "gdb_proc_service.h" ... > +linux-tile-low.o: linux-tile-low.c $(linux_low_h) $(server_h) This now needs to depend on $(gdb_proc_service_h) too. Otherwise looks fine. -- Pedro Alves