Re: [PATCH]testsuite: test for disconnected-tracing

[Hui Zhu <hui_zhu@mentor.com>]

On 04/11/12 13:44, Hui Zhu wrote:
> On 04/05/12 19:50, Pedro Alves wrote:
>> On 04/05/2012 09:14 AM, Hui Zhu wrote:
>>
>>> I post a new version patch according to your comments.
>>> And I have test it with gdb-7.4 and got fail.
>>
>>
>> Thanks.  Only a few nits remain, and this is technically ready to
>> check in.  See below.
>>
>> However, what's the status of your copyright assignment?  Last I
>> heard (and from what I see in FSF's copyright assignment records), we
>> still can't accept changes from you on behalf of Mentor.  :-(
>
> What I got is it is OK now.  I will send you a mail and cc the people that about the law.

Hi Pedro,

The copyright issue is OK now.  Do you think I can check in this patch?

Thanks,
Hui

>
>>
>>> 2012-04-05  Hui Zhu<hui_zhu@mentor.com>
>>>
>>>      * gdb.trace/Makefile.in (PROGS): Add
>>>      disconnected-tracing.
>>
>>
>> This fits fine on a single line.  Please do that.
>>
>>>      * gdb.trace/disconnected-tracing.c: New file.
>>>      * gdb.trace/disconnected-tracing.exp: New file.
>>>
>>
>>
>>> --- /dev/null
>>> +++ b/testsuite/gdb.trace/disconnected-tracing.c
>>
>> ...
>>
>>> +
>>> +int
>>> +main()
>>
>>
>> Might as well follow the coding standards, and add a space before parens.
>>
>>> +{
>>> +  return 0;
>>> +}
>>> \ No newline at end of file
>>
>>      ^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>> Please add a newline.
>>
>
> Post a new version according to your commnets.
>
> Thanks,
> Hui
>
> 2012-04-11  Hui Zhu  <hui_zhu@mentor.com>
>
>      * gdb.trace/Makefile.in (PROGS): Add disconnected-tracing.
>      * gdb.trace/disconnected-tracing.c: New file.
>      * gdb.trace/disconnected-tracing.exp: New file.