From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10575 invoked by alias); 10 May 2012 04:19:09 -0000 Received: (qmail 10562 invoked by uid 22791); 10 May 2012 04:19:05 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 May 2012 04:18:52 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1SSKq2-0003In-0F from Hui_Zhu@mentor.com ; Wed, 09 May 2012 21:18:50 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 9 May 2012 21:18:38 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Wed, 9 May 2012 21:18:16 -0700 Message-ID: <4FAB41A5.2020802@mentor.com> Date: Thu, 10 May 2012 04:19:00 -0000 From: Hui Zhu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120426 Thunderbird/13.0 MIME-Version: 1.0 To: Pedro Alves CC: Tom Tromey , Subject: Re: [PATCH]testsuite: test for disconnected-tracing References: <4F71C7F0.90209@mentor.com> <87iphoy2xx.fsf@fleche.redhat.com> <4F73B80C.7050703@mentor.com> <4F744956.4060500@redhat.com> <4F7D5456.9080806@mentor.com> <4F7D8715.9040509@redhat.com> <4F851A22.40809@mentor.com> In-Reply-To: <4F851A22.40809@mentor.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00327.txt.bz2 On 04/11/12 13:44, Hui Zhu wrote: > On 04/05/12 19:50, Pedro Alves wrote: >> On 04/05/2012 09:14 AM, Hui Zhu wrote: >> >>> I post a new version patch according to your comments. >>> And I have test it with gdb-7.4 and got fail. >> >> >> Thanks. Only a few nits remain, and this is technically ready to >> check in. See below. >> >> However, what's the status of your copyright assignment? Last I >> heard (and from what I see in FSF's copyright assignment records), we >> still can't accept changes from you on behalf of Mentor. :-( > > What I got is it is OK now. I will send you a mail and cc the people that about the law. Hi Pedro, The copyright issue is OK now. Do you think I can check in this patch? Thanks, Hui > >> >>> 2012-04-05 Hui Zhu >>> >>> * gdb.trace/Makefile.in (PROGS): Add >>> disconnected-tracing. >> >> >> This fits fine on a single line. Please do that. >> >>> * gdb.trace/disconnected-tracing.c: New file. >>> * gdb.trace/disconnected-tracing.exp: New file. >>> >> >> >>> --- /dev/null >>> +++ b/testsuite/gdb.trace/disconnected-tracing.c >> >> ... >> >>> + >>> +int >>> +main() >> >> >> Might as well follow the coding standards, and add a space before parens. >> >>> +{ >>> + return 0; >>> +} >>> \ No newline at end of file >> >> ^^^^^^^^^^^^^^^^^^^^^^^^^ >> >> Please add a newline. >> > > Post a new version according to your commnets. > > Thanks, > Hui > > 2012-04-11 Hui Zhu > > * gdb.trace/Makefile.in (PROGS): Add disconnected-tracing. > * gdb.trace/disconnected-tracing.c: New file. > * gdb.trace/disconnected-tracing.exp: New file.