From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Siddhesh Poyarekar <siddhesh@redhat.com>
Subject: Re: [commit] Do not rely on FIELD_LOC_KIND_BITPOS being zero
Date: Tue, 17 Apr 2012 13:09:00 -0000 [thread overview]
Message-ID: <4F8D695E.7070002@redhat.com> (raw)
In-Reply-To: <20120417124410.GA15356@host2.jankratochvil.net>
On 04/17/2012 01:44 PM, Jan Kratochvil wrote:
> Hi,
>
> FIELD_LOC_KIND_BITPOS is 0 and some code relied on it, using only
> TYPE_FIELD_BITPOS (type, n) = foo;
> instead of
> SET_FIELD_BITPOS (TYPE_FIELD (type, n), foo);
>
We could make the compiler catch these by making the macro return an rvalue.
---
gdb/gdbtypes.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index 07c3a86..9901439 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -1110,7 +1110,7 @@ extern void allocate_gnat_aux_type (struct type *);
#define TYPE_FIELD_TYPE(thistype, n) FIELD_TYPE(TYPE_FIELD(thistype, n))
#define TYPE_FIELD_NAME(thistype, n) FIELD_NAME(TYPE_FIELD(thistype, n))
#define TYPE_FIELD_LOC_KIND(thistype, n) FIELD_LOC_KIND (TYPE_FIELD (thistype, n))
-#define TYPE_FIELD_BITPOS(thistype, n) FIELD_BITPOS (TYPE_FIELD (thistype, n))
+#define TYPE_FIELD_BITPOS(thistype, n) (FIELD_BITPOS (TYPE_FIELD (thistype, n)) + 0)
#define TYPE_FIELD_STATIC_PHYSNAME(thistype, n) FIELD_STATIC_PHYSNAME (TYPE_FIELD (thistype, n))
#define TYPE_FIELD_STATIC_PHYSADDR(thistype, n) FIELD_STATIC_PHYSADDR (TYPE_FIELD (thistype, n))
#define TYPE_FIELD_DWARF_BLOCK(thistype, n) FIELD_DWARF_BLOCK (TYPE_FIELD (thistype, n))
next prev parent reply other threads:[~2012-04-17 13:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 12:52 Jan Kratochvil
2012-04-17 13:09 ` Pedro Alves [this message]
2012-04-17 13:57 ` Jan Kratochvil
2012-04-17 13:59 ` Pedro Alves
2012-04-17 14:03 ` Jan Kratochvil
2012-04-17 14:05 ` Pedro Alves
2012-04-17 14:11 ` Jan Kratochvil
2012-04-17 14:12 ` Pedro Alves
2012-04-17 14:16 ` Jan Kratochvil
2012-04-17 14:48 ` Tom Tromey
2012-04-17 14:52 ` Joel Brobecker
2012-04-17 14:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8D695E.7070002@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=siddhesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox