From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29765 invoked by alias); 17 Apr 2012 13:00:35 -0000 Received: (qmail 29756 invoked by uid 22791); 17 Apr 2012 13:00:34 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Apr 2012 13:00:16 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3HD0FUl013305 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 17 Apr 2012 09:00:15 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3HD0EnH028794; Tue, 17 Apr 2012 09:00:14 -0400 Message-ID: <4F8D695E.7070002@redhat.com> Date: Tue, 17 Apr 2012 13:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Jan Kratochvil CC: gdb-patches@sourceware.org, Siddhesh Poyarekar Subject: Re: [commit] Do not rely on FIELD_LOC_KIND_BITPOS being zero References: <20120417124410.GA15356@host2.jankratochvil.net> In-Reply-To: <20120417124410.GA15356@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00463.txt.bz2 On 04/17/2012 01:44 PM, Jan Kratochvil wrote: > Hi, > > FIELD_LOC_KIND_BITPOS is 0 and some code relied on it, using only > TYPE_FIELD_BITPOS (type, n) = foo; > instead of > SET_FIELD_BITPOS (TYPE_FIELD (type, n), foo); > We could make the compiler catch these by making the macro return an rvalue. --- gdb/gdbtypes.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h index 07c3a86..9901439 100644 --- a/gdb/gdbtypes.h +++ b/gdb/gdbtypes.h @@ -1110,7 +1110,7 @@ extern void allocate_gnat_aux_type (struct type *); #define TYPE_FIELD_TYPE(thistype, n) FIELD_TYPE(TYPE_FIELD(thistype, n)) #define TYPE_FIELD_NAME(thistype, n) FIELD_NAME(TYPE_FIELD(thistype, n)) #define TYPE_FIELD_LOC_KIND(thistype, n) FIELD_LOC_KIND (TYPE_FIELD (thistype, n)) -#define TYPE_FIELD_BITPOS(thistype, n) FIELD_BITPOS (TYPE_FIELD (thistype, n)) +#define TYPE_FIELD_BITPOS(thistype, n) (FIELD_BITPOS (TYPE_FIELD (thistype, n)) + 0) #define TYPE_FIELD_STATIC_PHYSNAME(thistype, n) FIELD_STATIC_PHYSNAME (TYPE_FIELD (thistype, n)) #define TYPE_FIELD_STATIC_PHYSADDR(thistype, n) FIELD_STATIC_PHYSADDR (TYPE_FIELD (thistype, n)) #define TYPE_FIELD_DWARF_BLOCK(thistype, n) FIELD_DWARF_BLOCK (TYPE_FIELD (thistype, n))