From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] Do not rely on FIELD_LOC_KIND_BITPOS being zero
Date: Tue, 17 Apr 2012 14:52:00 -0000 [thread overview]
Message-ID: <20120417144754.GK2852@adacore.com> (raw)
In-Reply-To: <4F8D76B7.90709@redhat.com>
> >> We could make the compiler catch these by making the macro return
> >> an rvalue.
[...]
> 2012-04-17 Pedro Alves <palves@redhat.com>
>
> * gdbtypes.h (FIELD_BITPOS): Rename to ...
> (FIELD_BITPOS_LVAL): ... this.
> (FIELD_BITPOS): New.
> (SET_FIELD_BITPOS): Adjust to use FIELD_BITPOS_LVAL.
> * dwarf2read.c (dwarf2_add_field): Use SET_FIELD_BITPOS.
> * gdbtypes.c (append_composite_type_field_aligned): Adjust to use
> SET_FIELD_BITPOS.
> * gnu-v3-abi.c (build_gdb_vtable_type): Adjust to use
> SET_FIELD_BITPOS.
> * stabsread.c (read_cpp_abbrev, read_one_struct_field)
> (read_baseclasses): Adjust to use SET_FIELD_BITPOS.
> * target-descriptions.c (tdesc_gdb_type): Adjust to use
> SET_FIELD_BITPOS.
Thanks for doing that, Pedro - I was going to suggest the same thing.
The more the compiler catches errors for us, the better!
--
Joel
next prev parent reply other threads:[~2012-04-17 14:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 12:52 Jan Kratochvil
2012-04-17 13:09 ` Pedro Alves
2012-04-17 13:57 ` Jan Kratochvil
2012-04-17 13:59 ` Pedro Alves
2012-04-17 14:03 ` Jan Kratochvil
2012-04-17 14:05 ` Pedro Alves
2012-04-17 14:11 ` Jan Kratochvil
2012-04-17 14:12 ` Pedro Alves
2012-04-17 14:16 ` Jan Kratochvil
2012-04-17 14:48 ` Tom Tromey
2012-04-17 14:52 ` Joel Brobecker [this message]
2012-04-17 14:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417144754.GK2852@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox