From: Yao Qi <yao@codesourcery.com>
To: Doug Evans <dje@google.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/5] s/struct process_info/struct inferior/
Date: Wed, 21 Mar 2012 03:18:00 -0000 [thread overview]
Message-ID: <4F6948A2.8000506@codesourcery.com> (raw)
In-Reply-To: <CADPb22TSUqY8OrPh61PHPoEA0PyZzmTB2CqMSxpT_WUH+obwmw@mail.gmail.com>
On 03/21/2012 12:28 AM, Doug Evans wrote:
> One thought that comes to mind is that if this renaming is good, then
> it's incomplete: rename current_process to current_inferior, and make
> similar changes throughout gdb. E.g., don't just change "struct
> process_info *process" to "struct inferior *process", change it to
> "struct inferior *inferior".
> Another example: rename linux_add_process to linux_add_inferior.
> [I realize it's more work, but to me the patch leaves gdb in a
> half-changed state otherwise.]
Agreed. If this change is a right way to go, I'll complete the left
renaming. I was not sure about people's thoughts on this change, so
sent a half-baked patch first.
--
Yao (é½å°§)
next prev parent reply other threads:[~2012-03-21 3:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 15:01 [PATCH 0/5] Preparatory patches for ITSET in GDBserver Yao Qi
2012-03-16 15:01 ` [PATCH 3/5] s/struct process_info/struct inferior/ Yao Qi
2012-03-20 16:28 ` Doug Evans
2012-03-20 17:55 ` Pedro Alves
2012-03-20 21:31 ` Doug Evans
2012-03-21 4:27 ` Yao Qi
2012-03-21 3:18 ` Yao Qi [this message]
2012-03-16 15:01 ` [PATCH 1/5] Define target_core_of_thread in gdbserver Yao Qi
2012-03-16 15:01 ` [PATCH 4/5] move server.h to inferior.h Yao Qi
2012-04-13 17:37 ` Tom Tromey
2012-03-16 15:02 ` [PATCH 2/5] Move vec to common/ Yao Qi
2012-03-16 15:02 ` [PATCH 5/5] move server.h to gdbthread.h Yao Qi
2012-04-13 17:43 ` Tom Tromey
2012-04-19 4:35 ` Yao Qi
2012-04-29 6:46 ` [committed]: " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6948A2.8000506@codesourcery.com \
--to=yao@codesourcery.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox