From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25918 invoked by alias); 21 Mar 2012 03:18:53 -0000 Received: (qmail 25910 invoked by uid 22791); 21 Mar 2012 03:18:52 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Mar 2012 03:18:37 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1SAC4K-0006j8-7M from Yao_Qi@mentor.com ; Tue, 20 Mar 2012 20:18:36 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 20 Mar 2012 20:18:35 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.1.289.1; Tue, 20 Mar 2012 20:18:34 -0700 Message-ID: <4F6948A2.8000506@codesourcery.com> Date: Wed, 21 Mar 2012 03:18:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120310 Thunderbird/11.0 MIME-Version: 1.0 To: Doug Evans CC: Subject: Re: [PATCH 3/5] s/struct process_info/struct inferior/ References: <1331909994-9473-1-git-send-email-yao@codesourcery.com> <1331909994-9473-4-git-send-email-yao@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00762.txt.bz2 On 03/21/2012 12:28 AM, Doug Evans wrote: > One thought that comes to mind is that if this renaming is good, then > it's incomplete: rename current_process to current_inferior, and make > similar changes throughout gdb. E.g., don't just change "struct > process_info *process" to "struct inferior *process", change it to > "struct inferior *inferior". > Another example: rename linux_add_process to linux_add_inferior. > [I realize it's more work, but to me the patch leaves gdb in a > half-changed state otherwise.] Agreed. If this change is a right way to go, I'll complete the left renaming. I was not sure about people's thoughts on this change, so sent a half-baked patch first. -- Yao (齐尧)