From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 4/5] move server.h to inferior.h
Date: Fri, 13 Apr 2012 17:37:00 -0000 [thread overview]
Message-ID: <871unry1qi.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1331909994-9473-5-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Fri, 16 Mar 2012 22:59:53 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> This patch moves some inferior-related code out server.h. This change
Yao> is not related to ITSET very much, but since we've put too mcuh stuff
Yao> into server.h, it is reasonable to put them in separate header files.
I'm not a gdbserver expert, but this seems reasonable to me.
However...
Yao> diff --git a/gdb/gdbserver/inferior.h b/gdb/gdbserver/inferior.h
Yao> new file mode 100644
Yao> index 0000000..5275efe
Yao> --- /dev/null
Yao> +++ b/gdb/gdbserver/inferior.h
Yao> @@ -0,0 +1,54 @@
Yao> +
Yao> +#ifndef INFERIOR_H
This file needs a copyright header.
Tom
next prev parent reply other threads:[~2012-04-13 17:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 15:01 [PATCH 0/5] Preparatory patches for ITSET in GDBserver Yao Qi
2012-03-16 15:01 ` [PATCH 3/5] s/struct process_info/struct inferior/ Yao Qi
2012-03-20 16:28 ` Doug Evans
2012-03-20 17:55 ` Pedro Alves
2012-03-20 21:31 ` Doug Evans
2012-03-21 4:27 ` Yao Qi
2012-03-21 3:18 ` Yao Qi
2012-03-16 15:01 ` [PATCH 4/5] move server.h to inferior.h Yao Qi
2012-04-13 17:37 ` Tom Tromey [this message]
2012-03-16 15:01 ` [PATCH 1/5] Define target_core_of_thread in gdbserver Yao Qi
2012-03-16 15:02 ` [PATCH 2/5] Move vec to common/ Yao Qi
2012-03-16 15:02 ` [PATCH 5/5] move server.h to gdbthread.h Yao Qi
2012-04-13 17:43 ` Tom Tromey
2012-04-19 4:35 ` Yao Qi
2012-04-29 6:46 ` [committed]: " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871unry1qi.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox