Re: [RFA] Fix mingw64 compilation

Re: [RFA] Fix mingw64 compilation

[Pedro Alves]

On 03/16/2012 10:17 AM, Pierre Muller wrote:

> One more native target 
> that was not yet fixed for -Wmissing-prototypes
> option.
> 
> This is a simple adaptation of what
> is in i386-windows-nat.c.
> 
> I didn't use OBVIOUS rule
> as I don't know if there was a 'better' 
> comment to put before...


If it was good for i386-windows-nat.c, then this should be good.
If it wasn't, then whoever wants to change it can change both
i386-windows-nat.c and amd64-windows-nat.c at the same time in
a follow up patch, using just about the same effort as just
changing i386-windows-nat.c now.

IOW, just go ahead and commit this to fix the build.

-- 
Pedro Alves

RE: [RFA] Fix mingw64 compilation

[Pierre Muller]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyé : vendredi 16 mars 2012 11:27
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA] Fix mingw64 compilation
> 
> On 03/16/2012 10:17 AM, Pierre Muller wrote:
> 
> > One more native target
> > that was not yet fixed for -Wmissing-prototypes
> > option.
> >
> > This is a simple adaptation of what
> > is in i386-windows-nat.c.
> >
> > I didn't use OBVIOUS rule
> > as I don't know if there was a 'better'
> > comment to put before...
> 
> 
> If it was good for i386-windows-nat.c, then this should be good.
> If it wasn't, then whoever wants to change it can change both
> i386-windows-nat.c and amd64-windows-nat.c at the same time in
> a follow up patch, using just about the same effort as just
> changing i386-windows-nat.c now.
> 
> IOW, just go ahead and commit this to fix the build.
You are of course right,
I committed this patch.

Thanks for the approval,

Pierre

[RFA] Fix mingw64 compilation

[Pierre Muller]

One more native target 
that was not yet fixed for -Wmissing-prototypes
option.

This is a simple adaptation of what
is in i386-windows-nat.c.

I didn't use OBVIOUS rule
as I don't know if there was a 'better' 
comment to put before...



Pierre Muller
GDB pascal language maintainer

2012-03-16  Pierre Muller  <muller@ics.u-strasbg.fr>

        * amd64-windows-nat.c (_initialize_amd64_windows_nat):
        Add missing prototype.

Index: amd64-windows-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/amd64-windows-nat.c,v
retrieving revision 1.7
diff -u -p -r1.7 amd64-windows-nat.c
--- amd64-windows-nat.c 4 Jan 2012 08:16:56 -0000       1.7
+++ amd64-windows-nat.c 16 Mar 2012 10:12:46 -0000
@@ -85,6 +85,9 @@ static const int mappings[] =
 };
 #undef context_offset

+/* -Wmissing-prototypes */
+extern initialize_file_ftype _initialize_amd64_windows_nat;
+
 void
 _initialize_amd64_windows_nat (void)
 {