Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Pedro Alves'" <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFA] Fix mingw64 compilation
Date: Fri, 16 Mar 2012 10:55:00 -0000	[thread overview]
Message-ID: <002501cd0363$4b34ce90$e19e6bb0$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <4F63158C.7040600@redhat.com>



> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyé : vendredi 16 mars 2012 11:27
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA] Fix mingw64 compilation
> 
> On 03/16/2012 10:17 AM, Pierre Muller wrote:
> 
> > One more native target
> > that was not yet fixed for -Wmissing-prototypes
> > option.
> >
> > This is a simple adaptation of what
> > is in i386-windows-nat.c.
> >
> > I didn't use OBVIOUS rule
> > as I don't know if there was a 'better'
> > comment to put before...
> 
> 
> If it was good for i386-windows-nat.c, then this should be good.
> If it wasn't, then whoever wants to change it can change both
> i386-windows-nat.c and amd64-windows-nat.c at the same time in
> a follow up patch, using just about the same effort as just
> changing i386-windows-nat.c now.
> 
> IOW, just go ahead and commit this to fix the build.
You are of course right,
I committed this patch.

Thanks for the approval,

Pierre


  reply	other threads:[~2012-03-16 10:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4f631340.65b1b60a.6213.14dfSMTPIN_ADDED@mx.google.com>
2012-03-16 10:27 ` Pedro Alves
2012-03-16 10:55   ` Pierre Muller [this message]
2012-03-16 10:17 Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002501cd0363$4b34ce90$e19e6bb0$@muller@ics-cnrs.unistra.fr' \
    --to=pierre.muller@ics-cnrs.unistra.fr \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox