[patch] fix amd64bsd-nat.c compilation

[patch] fix amd64bsd-nat.c compilation

[Andreas Tobler]

Hi,

the below fixes these warnings:

/export/devel/src/gdb/head/src/gdb/amd64bsd-nat.c:170: warning: no 
previous prototype for 'amd64bsd_dr_set_control'
/export/devel/src/gdb/head/src/gdb/amd64bsd-nat.c:176: warning: no 
previous prototype for 'amd64bsd_dr_set_addr'
/export/devel/src/gdb/head/src/gdb/amd64bsd-nat.c:184: warning: no 
previous prototype for 'amd64bsd_dr_get_addr'
/export/devel/src/gdb/head/src/gdb/amd64bsd-nat.c:190: warning: no 
previous prototype for 'amd64bsd_dr_get_status'
/export/devel/src/gdb/head/src/gdb/amd64bsd-nat.c:196: warning: no 
previous prototype for 'amd64bsd_dr_get_control'
gmake[2]: *** [amd64bsd-nat.o] Error 1

Ok to commit?

Thanks,
Andreas

2012-03-11  Andreas Tobler  <andreast@fgznet.ch>

	* amd64bsd-nat.c: Include amd64bsd-nat.h


Index: amd64bsd-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/amd64bsd-nat.c,v
retrieving revision 1.20
diff -u -r1.20 amd64bsd-nat.c
--- amd64bsd-nat.c	9 Feb 2012 16:06:44 -0000	1.20
+++ amd64bsd-nat.c	11 Mar 2012 15:05:23 -0000
@@ -31,6 +31,7 @@
  #include <machine/reg.h>

  #include "amd64-tdep.h"
+#include "amd64bsd-nat.h"
  #include "amd64-nat.h"
  #include "inf-ptrace.h"

Re: [patch] fix amd64bsd-nat.c compilation

[Joel Brobecker]

> Ok to commit?
[...]
> 2012-03-11  Andreas Tobler  <andreast@fgznet.ch>
> 
> 	* amd64bsd-nat.c: Include amd64bsd-nat.h

Looks good to me. Please go ahead and commit.

Thanks for the fix,
-- 
Joel

Re: [patch] fix amd64bsd-nat.c compilation

[Andreas Tobler]

On 12.03.12 06:02, Joel Brobecker wrote:
>> Ok to commit?
> [...]
>> 2012-03-11  Andreas Tobler<andreast@fgznet.ch>
>>
>> 	* amd64bsd-nat.c: Include amd64bsd-nat.h
>
> Looks good to me. Please go ahead and commit.
>
> Thanks for the fix,

Done. Thank you for the review!

Andreas

Re: [patch] fix amd64bsd-nat.c compilation

[Mark Kettenis]

> Date: Sun, 11 Mar 2012 22:02:32 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> 
> > Ok to commit?
> [...]
> > 2012-03-11  Andreas Tobler  <andreast@fgznet.ch>
> > 
> > 	* amd64bsd-nat.c: Include amd64bsd-nat.h
> 
> Looks good to me. Please go ahead and commit.

But when you do, please include amd64bsd-nat.h after amd64-nat.h
instead of before.

Re: [patch] fix amd64bsd-nat.c compilation

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

> > > 2012-03-11  Andreas Tobler  <andreast@fgznet.ch>
> > > 
> > > 	* amd64bsd-nat.c: Include amd64bsd-nat.h
> > 
> > Looks good to me. Please go ahead and commit.
> 
> But when you do, please include amd64bsd-nat.h after amd64-nat.h
> instead of before.

Sorry, Mark. Here is the fix I just applied. I couldn't verify
that it builds, but it should be safe.

-- 
Joel

[-- Attachment #2: 0001-amd64bsd-nat.c-Move-amd64bsd-nat.h-include.patch --]
[-- Type: text/x-diff, Size: 1187 bytes --]

From d70ca0de856042535c1f623c886b1a10d130aa3e Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Mon, 12 Mar 2012 08:19:06 -0700
Subject: [PATCH] amd64bsd-nat.c: Move "amd64bsd-nat.h" include...

... after include of "amd64-nat.h".

gdb/ChangeLog:

        * amd64bsd-nat.c: Move #include of "amd64bsd-nat.h" after
        include of "amd64-nat.h".
---
 gdb/ChangeLog      |    5 +++++
 gdb/amd64bsd-nat.c |    2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e4d1453..98d380e 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2012-03-12  Joel Brobecker  <brobecker@adacore.com>
+
+	* amd64bsd-nat.c: Move #include of "amd64bsd-nat.h" after
+	include of "amd64-nat.h".
+
 2012-03-12  Tom Tromey  <tromey@redhat.com>
 
 	* buildsym.c (record_pending_block): Now static.
diff --git a/gdb/amd64bsd-nat.c b/gdb/amd64bsd-nat.c
index 5684a01..83e7ec2 100644
--- a/gdb/amd64bsd-nat.c
+++ b/gdb/amd64bsd-nat.c
@@ -31,8 +31,8 @@
 #include <machine/reg.h>
 
 #include "amd64-tdep.h"
-#include "amd64bsd-nat.h"
 #include "amd64-nat.h"
+#include "amd64bsd-nat.h"
 #include "inf-ptrace.h"
 \f
 
-- 
1.7.1