From: Joel Brobecker <brobecker@adacore.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: andreast-list@fgznet.ch, gdb-patches@sourceware.org
Subject: Re: [patch] fix amd64bsd-nat.c compilation
Date: Mon, 12 Mar 2012 15:23:00 -0000 [thread overview]
Message-ID: <20120312152307.GA17806@adacore.com> (raw)
In-Reply-To: <201203120755.q2C7tB6O005959@glazunov.sibelius.xs4all.nl>
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
> > > 2012-03-11 Andreas Tobler <andreast@fgznet.ch>
> > >
> > > * amd64bsd-nat.c: Include amd64bsd-nat.h
> >
> > Looks good to me. Please go ahead and commit.
>
> But when you do, please include amd64bsd-nat.h after amd64-nat.h
> instead of before.
Sorry, Mark. Here is the fix I just applied. I couldn't verify
that it builds, but it should be safe.
--
Joel
[-- Attachment #2: 0001-amd64bsd-nat.c-Move-amd64bsd-nat.h-include.patch --]
[-- Type: text/x-diff, Size: 1187 bytes --]
From d70ca0de856042535c1f623c886b1a10d130aa3e Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Mon, 12 Mar 2012 08:19:06 -0700
Subject: [PATCH] amd64bsd-nat.c: Move "amd64bsd-nat.h" include...
... after include of "amd64-nat.h".
gdb/ChangeLog:
* amd64bsd-nat.c: Move #include of "amd64bsd-nat.h" after
include of "amd64-nat.h".
---
gdb/ChangeLog | 5 +++++
gdb/amd64bsd-nat.c | 2 +-
2 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e4d1453..98d380e 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2012-03-12 Joel Brobecker <brobecker@adacore.com>
+
+ * amd64bsd-nat.c: Move #include of "amd64bsd-nat.h" after
+ include of "amd64-nat.h".
+
2012-03-12 Tom Tromey <tromey@redhat.com>
* buildsym.c (record_pending_block): Now static.
diff --git a/gdb/amd64bsd-nat.c b/gdb/amd64bsd-nat.c
index 5684a01..83e7ec2 100644
--- a/gdb/amd64bsd-nat.c
+++ b/gdb/amd64bsd-nat.c
@@ -31,8 +31,8 @@
#include <machine/reg.h>
#include "amd64-tdep.h"
-#include "amd64bsd-nat.h"
#include "amd64-nat.h"
+#include "amd64bsd-nat.h"
#include "inf-ptrace.h"
\f
--
1.7.1
prev parent reply other threads:[~2012-03-12 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 15:14 Andreas Tobler
2012-03-12 5:02 ` Joel Brobecker
2012-03-12 5:28 ` Andreas Tobler
2012-03-12 7:56 ` Mark Kettenis
2012-03-12 15:23 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120312152307.GA17806@adacore.com \
--to=brobecker@adacore.com \
--cc=andreast-list@fgznet.ch \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox