From: Keith Seitz <keiths@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] gdb_get_line_number on unknown tags
Date: Thu, 08 Mar 2012 22:20:00 -0000 [thread overview]
Message-ID: <4F59308B.60605@redhat.com> (raw)
In-Reply-To: <8762een3u2.fsf@fleche.redhat.com>
On 03/08/2012 02:08 PM, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz<keiths@redhat.com> writes:
>
> Keith> This is occurring because the two tests which do it are using
> Keith> gdb_get_line_number on a tag which is not defined in the source
> Keith> file.
>
> I wonder whether this should be an error.
According to gdb.exp, gdb_get_line_number is supposed to return -1, but
I agree: I think gdb_get_line_number should throw an error. If you would
like, I can work up a patch for that. Just ping my on IRC.
> Keith> 2012-03-08 Keith Seitz<keiths@redhat.com>
>
> Keith> * gdb.ada/array_bounds.exp: Get breakpoint for line
> Keith> with "START", not "STOP".
> Keith> * gdb.python/py-infthread.exp: Do not continue to
> Keith> line marked "Break here.", which is undefined.
>
> Ok.
Committed. Thank you!
Keith
next prev parent reply other threads:[~2012-03-08 22:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 22:02 Keith Seitz
2012-03-08 22:08 ` Tom Tromey
2012-03-08 22:20 ` Keith Seitz [this message]
2012-03-08 22:24 ` Joel Brobecker
2012-03-08 23:15 ` Keith Seitz
2012-03-08 23:30 ` Joel Brobecker
2012-03-09 2:55 ` Tom Tromey
2012-03-09 4:39 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F59308B.60605@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox