From: Joel Brobecker <brobecker@adacore.com>
To: Keith Seitz <keiths@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>,
"gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] gdb_get_line_number on unknown tags
Date: Thu, 08 Mar 2012 23:30:00 -0000 [thread overview]
Message-ID: <20120308233030.GW2853@adacore.com> (raw)
In-Reply-To: <4F593D51.6020105@redhat.com>
> Well, we three agree, so here it is. It exposed buglets in three
> other tests (which appear to be copies of one common file).
[...]
> testsuite/ChangeLog
> 2012-03-08 Keith Seitz <keiths@redhat.com>
>
> * lib/gdb.exp (gdb_get_line_number): Throw an
> error instead of returning -1.
> * gdb.base/break.exp: Remove unused variable
> bp_location5.
> * gdb.base/hbreak2.exp: Likewise.
> * gdb.base/sepdebug.exp: Likewise.
Nice! This looks good to me. But perhaps Tom, who know TCL way better
than I do (and most likely you do too), might want to comment too?
The changes in gdb.base can go in as obvious on their own in any case.
--
Joel
next prev parent reply other threads:[~2012-03-08 23:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 22:02 Keith Seitz
2012-03-08 22:08 ` Tom Tromey
2012-03-08 22:20 ` Keith Seitz
2012-03-08 22:24 ` Joel Brobecker
2012-03-08 23:15 ` Keith Seitz
2012-03-08 23:30 ` Joel Brobecker [this message]
2012-03-09 2:55 ` Tom Tromey
2012-03-09 4:39 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308233030.GW2853@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox