From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10059 invoked by alias); 8 Mar 2012 23:30:52 -0000 Received: (qmail 10051 invoked by uid 22791); 8 Mar 2012 23:30:51 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Mar 2012 23:30:38 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 06A991C6494; Thu, 8 Mar 2012 18:30:38 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id TKIxY2eSUgvt; Thu, 8 Mar 2012 18:30:37 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id BFBD81C6481; Thu, 8 Mar 2012 18:30:37 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 944DE145615; Thu, 8 Mar 2012 15:30:30 -0800 (PST) Date: Thu, 08 Mar 2012 23:30:00 -0000 From: Joel Brobecker To: Keith Seitz Cc: Tom Tromey , "gdb-patches@sourceware.org ml" Subject: Re: [RFA] gdb_get_line_number on unknown tags Message-ID: <20120308233030.GW2853@adacore.com> References: <4F592C48.7000500@redhat.com> <8762een3u2.fsf@fleche.redhat.com> <20120308222412.GU2853@adacore.com> <4F593D51.6020105@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F593D51.6020105@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00307.txt.bz2 > Well, we three agree, so here it is. It exposed buglets in three > other tests (which appear to be copies of one common file). [...] > testsuite/ChangeLog > 2012-03-08 Keith Seitz > > * lib/gdb.exp (gdb_get_line_number): Throw an > error instead of returning -1. > * gdb.base/break.exp: Remove unused variable > bp_location5. > * gdb.base/hbreak2.exp: Likewise. > * gdb.base/sepdebug.exp: Likewise. Nice! This looks good to me. But perhaps Tom, who know TCL way better than I do (and most likely you do too), might want to comment too? The changes in gdb.base can go in as obvious on their own in any case. -- Joel