From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16691 invoked by alias); 8 Mar 2012 22:20:17 -0000 Received: (qmail 16666 invoked by uid 22791); 8 Mar 2012 22:20:15 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Mar 2012 22:19:58 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q28MJvlU022512 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 8 Mar 2012 17:19:57 -0500 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q28MJtV2031092 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 8 Mar 2012 17:19:57 -0500 Message-ID: <4F59308B.60605@redhat.com> Date: Thu, 08 Mar 2012 22:20:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Tom Tromey CC: "gdb-patches@sourceware.org ml" Subject: Re: [RFA] gdb_get_line_number on unknown tags References: <4F592C48.7000500@redhat.com> <8762een3u2.fsf@fleche.redhat.com> In-Reply-To: <8762een3u2.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00296.txt.bz2 On 03/08/2012 02:08 PM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > > Keith> This is occurring because the two tests which do it are using > Keith> gdb_get_line_number on a tag which is not defined in the source > Keith> file. > > I wonder whether this should be an error. According to gdb.exp, gdb_get_line_number is supposed to return -1, but I agree: I think gdb_get_line_number should throw an error. If you would like, I can work up a patch for that. Just ping my on IRC. > Keith> 2012-03-08 Keith Seitz > > Keith> * gdb.ada/array_bounds.exp: Get breakpoint for line > Keith> with "START", not "STOP". > Keith> * gdb.python/py-infthread.exp: Do not continue to > Keith> line marked "Break here.", which is undefined. > > Ok. Committed. Thank you! Keith