From: Pedro Alves <palves@redhat.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: Tom Tromey <tromey@redhat.com>,
gdb-patches@sourceware.org,
Keith Seitz <keiths@redhat.com>
Subject: Re: [PATCH] remote: Fix a crash on longjmp breakpoint removal
Date: Wed, 07 Mar 2012 20:47:00 -0000 [thread overview]
Message-ID: <4F57C92F.7010501@redhat.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1203070448160.14492@tp.orcam.me.uk>
On 03/07/2012 08:08 PM, Maciej W. Rozycki wrote:
> So I have finally got back to it and noticed that this:
>
> http://sourceware.org/ml/gdb-patches/2012-01/msg00701.html
>
> has already fixed the problem -- shall we close gdb/13333 then?
If it's fixed, yes.
> I think we should still add Keith's test case to cover any possible future
> breakage in this area -- the fix didn't include any.
py-finish-breakpoint.exp was failing against gdbserver without the fix.
I don't mind adding a new test. Keith's was using gdb_expect, which we
very much like to avoid. Can it be made to use gdb_test or
gdb_test_multiple?
> I suggest that we retrofit the ChangeLog entry with a reference too.
Please go ahead.
--
Pedro Alves
next prev parent reply other threads:[~2012-03-07 20:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 21:13 Maciej W. Rozycki
2011-12-20 16:00 ` Tom Tromey
2012-03-07 20:08 ` Maciej W. Rozycki
2012-03-07 20:47 ` Pedro Alves [this message]
2012-03-07 20:48 ` Keith Seitz
2012-03-10 2:55 ` Maciej W. Rozycki
2012-03-10 4:48 ` Keith Seitz
2012-03-10 5:11 ` Keith Seitz
2012-03-12 18:13 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F57C92F.7010501@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=macro@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox