Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "Maciej W. Rozycki" <macro@codesourcery.com>,
	       Pedro Alves <palves@redhat.com>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH] remote: Fix a crash on longjmp breakpoint removal
Date: Mon, 12 Mar 2012 18:13:00 -0000	[thread overview]
Message-ID: <4F5E3C9B.8070608@redhat.com> (raw)
In-Reply-To: <4F5AE26F.8050800@redhat.com>

On 03/10/2012 05:11 AM, Keith Seitz wrote:

> On 03/09/2012 08:48 PM, Keith Seitz wrote:
>> On 03/09/2012 06:55 PM, Maciej W. Rozycki wrote:
>>> Keith, would you care updating your test case then? I'm going to be away
>>> for two weeks and won't be able to look into it any sooner.
>>
>> Sure thing.
> 
> I've changed the test a little bit to safeguard against looping forever. Pedro, does this look acceptable?
> 


I was going to say there's really nothing target specific in the test, and
that thus it's best to put it under gdb.base/ (well I just did :-) ), but then I
remembered Tom's quite new gdb.base/nextoverexit.exp test that tests the exact
same (albeit in an even simpler form).  I've checked out a tree from just before
my fix, and run it against nextoverexit.exp w/ gdbserver (didn't exist at the
time, so I copied it over), and indeed GDB crashes.

So we don't really need this new test; it's redundant.  Sorry for not realizing
this before you went for the trouble of updating the test...  :-/

-- 
Pedro Alves


      reply	other threads:[~2012-03-12 18:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-13 21:13 Maciej W. Rozycki
2011-12-20 16:00 ` Tom Tromey
2012-03-07 20:08   ` Maciej W. Rozycki
2012-03-07 20:47     ` Pedro Alves
2012-03-07 20:48       ` Keith Seitz
2012-03-10  2:55         ` Maciej W. Rozycki
2012-03-10  4:48           ` Keith Seitz
2012-03-10  5:11             ` Keith Seitz
2012-03-12 18:13               ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5E3C9B.8070608@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    --cc=macro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox