From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 624 invoked by alias); 7 Mar 2012 20:47:02 -0000 Received: (qmail 611 invoked by uid 22791); 7 Mar 2012 20:47:01 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_GJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Mar 2012 20:46:44 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q27Kkfjm012687 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 7 Mar 2012 15:46:41 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q27KkdD4029072; Wed, 7 Mar 2012 15:46:39 -0500 Message-ID: <4F57C92F.7010501@redhat.com> Date: Wed, 07 Mar 2012 20:47:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: "Maciej W. Rozycki" CC: Tom Tromey , gdb-patches@sourceware.org, Keith Seitz Subject: Re: [PATCH] remote: Fix a crash on longjmp breakpoint removal References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00248.txt.bz2 On 03/07/2012 08:08 PM, Maciej W. Rozycki wrote: > So I have finally got back to it and noticed that this: > > http://sourceware.org/ml/gdb-patches/2012-01/msg00701.html > > has already fixed the problem -- shall we close gdb/13333 then? If it's fixed, yes. > I think we should still add Keith's test case to cover any possible future > breakage in this area -- the fix didn't include any. py-finish-breakpoint.exp was failing against gdbserver without the fix. I don't mind adding a new test. Keith's was using gdb_expect, which we very much like to avoid. Can it be made to use gdb_test or gdb_test_multiple? > I suggest that we retrofit the ChangeLog entry with a reference too. Please go ahead. -- Pedro Alves