Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <alves.ped@gmail.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>,
	 Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
	'Joel Brobecker' <brobecker@adacore.com>,
	gdb-patches@sourceware.org,
	 'Sergio Durigan' <sdurigan@redhat.com>,
	'Kai Tietz' <ktietz@redhat.com>
Subject: Re: [commit] [patch 1/2] Drop gdbtui [+doc changes]
Date: Mon, 02 Jan 2012 13:03:00 -0000	[thread overview]
Message-ID: <4F01AB13.3030307@gmail.com> (raw)
In-Reply-To: <20120102023006.GA15664@host2.jankratochvil.net>

On 01/02/2012 02:30 AM, Jan Kratochvil wrote:
> --- src/gdb/main.c	2011/11/05 17:08:30	1.97
> +++ src/gdb/main.c	2012/01/02 02:28:58	1.98
> @@ -380,7 +380,7 @@
>        this captured main, or one specified by the user at start up, or
>        the console.  Initialize the interpreter to the one requested by
>        the application.  */
> -  interpreter_p = xstrdup (context->interpreter_p);
> +  interpreter_p = xstrdup (INTERP_CONSOLE);
>
>     /* Parse arguments and options.  */
>     {
> --- src/gdb/main.h	2011/01/01 15:33:10	1.12
> +++ src/gdb/main.h	2012/01/02 02:28:58	1.13
> @@ -26,7 +26,6 @@
>     int argc;
>     char **argv;
>     int use_windows;
> -  const char *interpreter_p;
>   };

This breaks 'insight' the binary, which similarly to gdbtui,
starts gdb with the "insight" interpreter.

gdbtk-main.c:
int
main (int argc, char **argv)
{
   struct captured_main_args args;
   memset (&args, 0, sizeof args);
   args.argc = argc;
   args.argv = argv;
   args.use_windows = 1;
   args.interpreter_p = "insight";
   return gdb_main (&args);
}

-- 
Pedro Alves


  reply	other threads:[~2012-01-02 13:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-21 11:47 [patch 1/2] Make gdbtui a shell script Jan Kratochvil
2011-12-21 12:53 ` Joel Brobecker
2011-12-21 14:25   ` Jan Kratochvil
2011-12-21 14:32     ` Pierre Muller
2011-12-21 14:39       ` Jan Kratochvil
2011-12-21 17:11         ` Joel Brobecker
2011-12-21 18:37         ` Tom Tromey
2011-12-21 23:11           ` [patch 1/2] Drop gdbtui [+doc changes] Jan Kratochvil
2011-12-22  8:11             ` Eli Zaretskii
2011-12-22  9:53               ` Jan Kratochvil
2011-12-22 11:33                 ` Eli Zaretskii
2011-12-22 17:15                   ` Jan Kratochvil
2012-01-02  2:30             ` [commit] " Jan Kratochvil
2012-01-02 13:03               ` Pedro Alves [this message]
2012-01-02 13:32                 ` [commit] Fix/revert insight build regression by me [Re: [commit] [patch 1/2] Drop gdbtui [+doc changes]] Jan Kratochvil
2011-12-21 23:39   ` [patch 1/2] Make gdbtui a shell script Stan Shebs
2011-12-22  6:26     ` Joel Brobecker
2011-12-22 10:16       ` [NEWS patch] " Jan Kratochvil
2012-01-01 21:52         ` [commit 7.4] " Jan Kratochvil
2011-12-21 17:26 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F01AB13.3030307@gmail.com \
    --to=alves.ped@gmail.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=ktietz@redhat.com \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    --cc=sdurigan@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox