From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31654 invoked by alias); 2 Jan 2012 13:03:34 -0000 Received: (qmail 31645 invoked by uid 22791); 2 Jan 2012 13:03:33 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_50,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_DB X-Spam-Check-By: sourceware.org Received: from mail-ww0-f41.google.com (HELO mail-ww0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Jan 2012 13:03:20 +0000 Received: by wgbdt12 with SMTP id dt12so23608161wgb.0 for ; Mon, 02 Jan 2012 05:03:19 -0800 (PST) Received: by 10.216.136.17 with SMTP id v17mr5642789wei.13.1325509399169; Mon, 02 Jan 2012 05:03:19 -0800 (PST) Received: from [192.168.0.103] (bl16-31-110.dsl.telepac.pt. [188.81.31.110]) by mx.google.com with ESMTPS id u5sm50544699wbm.2.2012.01.02.05.03.16 (version=SSLv3 cipher=OTHER); Mon, 02 Jan 2012 05:03:18 -0800 (PST) Message-ID: <4F01AB13.3030307@gmail.com> Date: Mon, 02 Jan 2012 13:03:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Jan Kratochvil CC: Tom Tromey , Pierre Muller , 'Joel Brobecker' , gdb-patches@sourceware.org, 'Sergio Durigan' , 'Kai Tietz' Subject: Re: [commit] [patch 1/2] Drop gdbtui [+doc changes] References: <20111221114641.GB25652@host2.jankratochvil.net> <20111221122330.GH23376@adacore.com> <20111221142328.GA8079@host2.jankratochvil.net> <005b01ccbfec$97428d50$c5c7a7f0$@muller@ics-cnrs.unistra.fr> <20111221143139.GA12714@host2.jankratochvil.net> <20111221223523.GA14268@host2.jankratochvil.net> <20120102023006.GA15664@host2.jankratochvil.net> In-Reply-To: <20120102023006.GA15664@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00031.txt.bz2 On 01/02/2012 02:30 AM, Jan Kratochvil wrote: > --- src/gdb/main.c 2011/11/05 17:08:30 1.97 > +++ src/gdb/main.c 2012/01/02 02:28:58 1.98 > @@ -380,7 +380,7 @@ > this captured main, or one specified by the user at start up, or > the console. Initialize the interpreter to the one requested by > the application. */ > - interpreter_p = xstrdup (context->interpreter_p); > + interpreter_p = xstrdup (INTERP_CONSOLE); > > /* Parse arguments and options. */ > { > --- src/gdb/main.h 2011/01/01 15:33:10 1.12 > +++ src/gdb/main.h 2012/01/02 02:28:58 1.13 > @@ -26,7 +26,6 @@ > int argc; > char **argv; > int use_windows; > - const char *interpreter_p; > }; This breaks 'insight' the binary, which similarly to gdbtui, starts gdb with the "insight" interpreter. gdbtk-main.c: int main (int argc, char **argv) { struct captured_main_args args; memset (&args, 0, sizeof args); args.argc = argc; args.argv = argv; args.use_windows = 1; args.interpreter_p = "insight"; return gdb_main (&args); } -- Pedro Alves