From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <alves.ped@gmail.com>
Cc: Tom Tromey <tromey@redhat.com>,
Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
"'Joel Brobecker'" <brobecker@adacore.com>,
gdb-patches@sourceware.org,
"'Sergio Durigan'" <sdurigan@redhat.com>,
"'Kai Tietz'" <ktietz@redhat.com>
Subject: [commit] Fix/revert insight build regression by me [Re: [commit] [patch 1/2] Drop gdbtui [+doc changes]]
Date: Mon, 02 Jan 2012 13:32:00 -0000 [thread overview]
Message-ID: <20120102133150.GA19010@host2.jankratochvil.net> (raw)
In-Reply-To: <4F01AB13.3030307@gmail.com>
On Mon, 02 Jan 2012 14:03:15 +0100, Pedro Alves wrote:
> This breaks 'insight' the binary, which similarly to gdbtui,
> starts gdb with the "insight" interpreter.
./gdbtk/generic/gdbtk-main.c: In function ‘main’:
./gdbtk/generic/gdbtk-main.c:35:7: error: ‘struct captured_main_args’ has no member named ‘interpreter_p’
Thanks for catching it. Checked in the revert below.
Regards,
Jan
http://sourceware.org/ml/gdb-cvs/2012-01/msg00019.html
--- src/gdb/ChangeLog 2012/01/02 09:03:07 1.13688
+++ src/gdb/ChangeLog 2012/01/02 13:29:55 1.13689
@@ -1,3 +1,12 @@
+2012-01-02 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ Revert this part of:
+ 2012-01-02 Jan Kratochvil <jan.kratochvil@redhat.com>
+ Remove the gdbtui binary.
+ * gdb.c (main): Remove args.interpreter_p initialization.
+ * main.c (captured_main): Set INTERPRETER_P directly by INTERP_CONSOLE.
+ * main.h (struct captured_main_args): Remove interpreter_p.
+
2012-01-02 Joel Brobecker <brobecker@adacore.com>
* config/djgpp/fnchange.lst: Add entry for ChangeLog-2011.
--- src/gdb/gdb.c 2012/01/02 02:28:58 1.13
+++ src/gdb/gdb.c 2012/01/02 13:29:57 1.14
@@ -31,5 +31,6 @@
args.argc = argc;
args.argv = argv;
args.use_windows = 0;
+ args.interpreter_p = INTERP_CONSOLE;
return gdb_main (&args);
}
--- src/gdb/main.c 2012/01/02 02:28:58 1.98
+++ src/gdb/main.c 2012/01/02 13:29:57 1.99
@@ -380,7 +380,7 @@
this captured main, or one specified by the user at start up, or
the console. Initialize the interpreter to the one requested by
the application. */
- interpreter_p = xstrdup (INTERP_CONSOLE);
+ interpreter_p = xstrdup (context->interpreter_p);
/* Parse arguments and options. */
{
--- src/gdb/main.h 2012/01/02 02:28:58 1.13
+++ src/gdb/main.h 2012/01/02 13:29:57 1.14
@@ -26,6 +26,7 @@
int argc;
char **argv;
int use_windows;
+ const char *interpreter_p;
};
extern int gdb_main (struct captured_main_args *);
next prev parent reply other threads:[~2012-01-02 13:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 11:47 [patch 1/2] Make gdbtui a shell script Jan Kratochvil
2011-12-21 12:53 ` Joel Brobecker
2011-12-21 14:25 ` Jan Kratochvil
2011-12-21 14:32 ` Pierre Muller
2011-12-21 14:39 ` Jan Kratochvil
2011-12-21 17:11 ` Joel Brobecker
2011-12-21 18:37 ` Tom Tromey
2011-12-21 23:11 ` [patch 1/2] Drop gdbtui [+doc changes] Jan Kratochvil
2011-12-22 8:11 ` Eli Zaretskii
2011-12-22 9:53 ` Jan Kratochvil
2011-12-22 11:33 ` Eli Zaretskii
2011-12-22 17:15 ` Jan Kratochvil
2012-01-02 2:30 ` [commit] " Jan Kratochvil
2012-01-02 13:03 ` Pedro Alves
2012-01-02 13:32 ` Jan Kratochvil [this message]
2011-12-21 23:39 ` [patch 1/2] Make gdbtui a shell script Stan Shebs
2011-12-22 6:26 ` Joel Brobecker
2011-12-22 10:16 ` [NEWS patch] " Jan Kratochvil
2012-01-01 21:52 ` [commit 7.4] " Jan Kratochvil
2011-12-21 17:26 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120102133150.GA19010@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=alves.ped@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ktietz@redhat.com \
--cc=pierre.muller@ics-cnrs.unistra.fr \
--cc=sdurigan@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox