From: Pedro Alves <alves.ped@gmail.com>
To: Iain Sandoe <developer@sandoe-acoustics.co.uk>
Cc: gdb-patches@sourceware.org, Tristan Gingold <gingold@adacore.com>
Subject: Re: [Patch Darwin] head build fixes for i686-darwin9/x86_64-darwin10.
Date: Mon, 02 Jan 2012 11:40:00 -0000 [thread overview]
Message-ID: <4F01978A.8060306@gmail.com> (raw)
In-Reply-To: <59ABFF71-CA26-452C-B9B2-9B0FC6AAE2BD@sandoe-acoustics.co.uk>
On 12/29/2011 08:30 PM, Iain Sandoe wrote:
> =======
>
> 2/ DR_FIRSTADDR and cousins are undefined.
> (the fragment below is copied verbatim from gdb-7.3.1 - is there some
> reason to expect that it should have been defined elsewhere?)
I've just recently removed these from this file, but I missed that the file
does not include i386-nat.h. Include i386-nat.h instead please.
Darwin has the i386 watchpoint hooks in place, but it doesn't install
them --- there's a i386_use_watchpoints call missing (at least).
http://sourceware.org/ml/gdb-patches/2011-12/msg00143.html
>
> diff --git a/gdb/i386-darwin-nat.c b/gdb/i386-darwin-nat.c
> index 23f6a6d..2a346c4 100644
> --- a/gdb/i386-darwin-nat.c
> +++ b/gdb/i386-darwin-nat.c
> @@ -263,6 +263,22 @@ i386_darwin_store_inferior_registers (struct
> target_ops *ops,
>
> /* Support for debug registers, boosted mostly from
> i386-linux-nat.c. */
>
> +#ifndef DR_FIRSTADDR
> +#define DR_FIRSTADDR 0
> +#endif
> +
> +#ifndef DR_LASTADDR
> +#define DR_LASTADDR 3
> +#endif
> +
> +#ifndef DR_STATUS
> +#define DR_STATUS 6
> +#endif
> +
> +#ifndef DR_CONTROL
> +#define DR_CONTROL 7
> +#endif
> +
next prev parent reply other threads:[~2012-01-02 11:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 20:32 Iain Sandoe
2012-01-02 11:40 ` Pedro Alves [this message]
2012-01-02 14:39 ` Tristan Gingold
2012-12-24 3:57 ` Mike Frysinger
2012-12-24 4:27 ` Joel Brobecker
2012-12-24 5:09 ` Mike Frysinger
2012-12-24 3:56 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F01978A.8060306@gmail.com \
--to=alves.ped@gmail.com \
--cc=developer@sandoe-acoustics.co.uk \
--cc=gdb-patches@sourceware.org \
--cc=gingold@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox