From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4135 invoked by alias); 2 Jan 2012 11:40:20 -0000 Received: (qmail 4126 invoked by uid 22791); 2 Jan 2012 11:40:19 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-we0-f169.google.com (HELO mail-we0-f169.google.com) (74.125.82.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Jan 2012 11:39:58 +0000 Received: by werf1 with SMTP id f1so9712386wer.0 for ; Mon, 02 Jan 2012 03:39:56 -0800 (PST) Received: by 10.216.131.76 with SMTP id l54mr26780013wei.34.1325504396910; Mon, 02 Jan 2012 03:39:56 -0800 (PST) Received: from [192.168.0.103] (bl16-31-110.dsl.telepac.pt. [188.81.31.110]) by mx.google.com with ESMTPS id u5sm50263619wbm.2.2012.01.02.03.39.55 (version=SSLv3 cipher=OTHER); Mon, 02 Jan 2012 03:39:55 -0800 (PST) Message-ID: <4F01978A.8060306@gmail.com> Date: Mon, 02 Jan 2012 11:40:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Iain Sandoe CC: gdb-patches@sourceware.org, Tristan Gingold Subject: Re: [Patch Darwin] head build fixes for i686-darwin9/x86_64-darwin10. References: <59ABFF71-CA26-452C-B9B2-9B0FC6AAE2BD@sandoe-acoustics.co.uk> In-Reply-To: <59ABFF71-CA26-452C-B9B2-9B0FC6AAE2BD@sandoe-acoustics.co.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00027.txt.bz2 On 12/29/2011 08:30 PM, Iain Sandoe wrote: > ======= > > 2/ DR_FIRSTADDR and cousins are undefined. > (the fragment below is copied verbatim from gdb-7.3.1 - is there some > reason to expect that it should have been defined elsewhere?) I've just recently removed these from this file, but I missed that the file does not include i386-nat.h. Include i386-nat.h instead please. Darwin has the i386 watchpoint hooks in place, but it doesn't install them --- there's a i386_use_watchpoints call missing (at least). http://sourceware.org/ml/gdb-patches/2011-12/msg00143.html > > diff --git a/gdb/i386-darwin-nat.c b/gdb/i386-darwin-nat.c > index 23f6a6d..2a346c4 100644 > --- a/gdb/i386-darwin-nat.c > +++ b/gdb/i386-darwin-nat.c > @@ -263,6 +263,22 @@ i386_darwin_store_inferior_registers (struct > target_ops *ops, > > /* Support for debug registers, boosted mostly from > i386-linux-nat.c. */ > > +#ifndef DR_FIRSTADDR > +#define DR_FIRSTADDR 0 > +#endif > + > +#ifndef DR_LASTADDR > +#define DR_LASTADDR 3 > +#endif > + > +#ifndef DR_STATUS > +#define DR_STATUS 6 > +#endif > + > +#ifndef DR_CONTROL > +#define DR_CONTROL 7 > +#endif > +