Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org, Tristan Gingold <gingold@adacore.com>,
	Iain Sandoe <developer@sandoe-acoustics.co.uk>
Subject: Re: [Patch Darwin] head build fixes for i686-darwin9/x86_64-darwin10.
Date: Mon, 24 Dec 2012 04:27:00 -0000	[thread overview]
Message-ID: <20121224042657.GT5370@adacore.com> (raw)
In-Reply-To: <201212232258.05972.vapier@gentoo.org>

> how about this instead.  it localizes the #ifdef and has a comment.

Tristan being on holiday, I will take over this week. This looks
OK to me with one tiny request: Update the function documentation
about also returning -1 to signify that the request is unsupported.
I assume you'll remember to provide a CL.

I wonder how we are expected to iterate over shared libraries
on Darwin 9 (we no longer have access to this version of Darwin).

Thanks!

> diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c
> index 252fe3e..ac0aaac 100644
> --- a/gdb/darwin-nat.c
> +++ b/gdb/darwin-nat.c
> @@ -1821,6 +1821,10 @@ out:
>  static int
>  darwin_read_dyld_info (task_t task, CORE_ADDR addr, char *rdaddr, int length)
>  {
> +#ifndef TASK_DYLD_INFO_COUNT
> +  /* This is not available in Darwin 9.  */
> +  return -1;
> +#else
>    struct task_dyld_info task_dyld_info;
>    mach_msg_type_number_t count = TASK_DYLD_INFO_COUNT;
>    int sz = TASK_DYLD_INFO_COUNT * sizeof (natural_t);
> @@ -1838,6 +1842,7 @@ darwin_read_dyld_info (task_t task, CORE_ADDR addr, char 
> *rdaddr, int length)
>      length = sz - addr;
>    memcpy (rdaddr, (char *)&task_dyld_info + addr, length);
>    return length;
> +#endif
>  }
>  
>  \f
> -mike



-- 
Joel


  reply	other threads:[~2012-12-24  4:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-29 20:32 Iain Sandoe
2012-01-02 11:40 ` Pedro Alves
2012-01-02 14:39 ` Tristan Gingold
2012-12-24  3:57   ` Mike Frysinger
2012-12-24  4:27     ` Joel Brobecker [this message]
2012-12-24  5:09       ` Mike Frysinger
2012-12-24  3:56 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121224042657.GT5370@adacore.com \
    --to=brobecker@adacore.com \
    --cc=developer@sandoe-acoustics.co.uk \
    --cc=gdb-patches@sourceware.org \
    --cc=gingold@adacore.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox