From: asmwarrior <asmwarrior@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit] Improve gdb_realpath for Windows hosts
Date: Tue, 27 Dec 2011 16:26:00 -0000 [thread overview]
Message-ID: <4EF9D8B4.4050601@gmail.com> (raw)
In-Reply-To: <20111227141214.GH23376@adacore.com>
On 2011-12-27 22:12, Joel Brobecker wrote:
>> Can you explain that why you avoid converting to lowercase?
>>
>>> /* The file system is case-insensitive but case-preserving.
>>> So we do not lowercase the path. Otherwise, we might not
>>> be able to display the original casing in a given path. */
>> I just thought that lowercase is another canonization of path, so you
>> can have a uniform path when you set breakpoints(file specification)
> Two reasons, mostly:
> . It is unnecessary;
> . It changes the filename casing when displaying the name of
> the file where the breakpoint has been inserted.
>
> Several Windows users at AdaCore often complain that GNU tools do not
> properly preserve the filename casing, so I did not think it was
> proper for us to do so. Even as a Unix user, I do feel that it is
> important to preserve the casing as well.
>
> I should say that it does not affect filename matching, which is
> performed through another specialized function.
>
>> The original code in iberty library is like:
> Honestly, I do not understand why they do it. There is no correlation,
> IMO, between the fact that the FS is case-insensitive and the fact
> that you'd want to change the filename casing (again, doing something
> extra which is unnecessary, since it does not make a difference to
> the filesystem).
>
OK, I understand now. Thank you Joel for your explanation and your time.
asmwarrior
ollydbg from codeblocks' forum
prev parent reply other threads:[~2011-12-27 14:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 17:31 Joel Brobecker
2011-12-22 17:59 ` Eli Zaretskii
2011-12-22 18:16 ` Joel Brobecker
2011-12-27 4:11 ` Checked in: " Joel Brobecker
2011-12-27 12:40 ` asmwarrior
2011-12-27 13:47 ` Joel Brobecker
2011-12-27 14:00 ` asmwarrior
2011-12-27 14:12 ` asmwarrior
2011-12-27 14:35 ` Joel Brobecker
2011-12-27 16:26 ` asmwarrior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF9D8B4.4050601@gmail.com \
--to=asmwarrior@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox