From: asmwarrior <asmwarrior@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit] Improve gdb_realpath for Windows hosts
Date: Tue, 27 Dec 2011 14:00:00 -0000 [thread overview]
Message-ID: <4EF9CD4D.8050503@gmail.com> (raw)
In-Reply-To: <20111227124009.GG23376@adacore.com>
On 2011-12-27 20:40, Joel Brobecker wrote:
>> Someone said that "MAX_PATH" is not enough about several months ago
>> > when we were discussing some breakpoint issue see:
>> > http://sourceware.org/ml/gdb/2011-06/msg00101.html
> My understanding is:
> - The way this function is called, its output is limited to MAX_PATH;
> - If the canonialized path does in fact exceed MAX_PATH, then
> the canonicalization fails, and we fallback on the old way
> (strdup).
>
> So I do not see the problem with the current approach. There might
> be a better implementation, allowing longer paths, but this is
> already better than before. And if there is a better implementation
> indeed, it does need to work on all supported versions of Windows
> (I think we need to support at least as back as XP, possibly older).
>
> -- Joel
Yeah, I agree with you. In fact, I use such patch locally in my XP for months without any problems.:-)
asmwarrior
ollydbg from codeblocks' forum
next prev parent reply other threads:[~2011-12-27 13:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 17:31 Joel Brobecker
2011-12-22 17:59 ` Eli Zaretskii
2011-12-22 18:16 ` Joel Brobecker
2011-12-27 4:11 ` Checked in: " Joel Brobecker
2011-12-27 12:40 ` asmwarrior
2011-12-27 13:47 ` Joel Brobecker
2011-12-27 14:00 ` asmwarrior [this message]
2011-12-27 14:12 ` asmwarrior
2011-12-27 14:35 ` Joel Brobecker
2011-12-27 16:26 ` asmwarrior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF9CD4D.8050503@gmail.com \
--to=asmwarrior@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox