From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32736 invoked by alias); 27 Dec 2011 13:47:11 -0000 Received: (qmail 32726 invoked by uid 22791); 27 Dec 2011 13:47:10 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_DB X-Spam-Check-By: sourceware.org Received: from mail-tul01m020-f169.google.com (HELO mail-tul01m020-f169.google.com) (209.85.214.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Dec 2011 13:46:57 +0000 Received: by obcwo8 with SMTP id wo8so8829170obc.0 for ; Tue, 27 Dec 2011 05:46:56 -0800 (PST) Received: by 10.50.47.228 with SMTP id g4mr31479070ign.14.1324993616433; Tue, 27 Dec 2011 05:46:56 -0800 (PST) Received: from [192.168.1.103] ([218.109.117.104]) by mx.google.com with ESMTPS id l28sm90281421ibc.3.2011.12.27.05.46.53 (version=SSLv3 cipher=OTHER); Tue, 27 Dec 2011 05:46:55 -0800 (PST) Message-ID: <4EF9CD4D.8050503@gmail.com> Date: Tue, 27 Dec 2011 14:00:00 -0000 From: asmwarrior User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [RFA/commit] Improve gdb_realpath for Windows hosts References: <1324574084-7971-1-git-send-email-brobecker@adacore.com> <4EF9B94C.7030204@gmail.com> <20111227124009.GG23376@adacore.com> In-Reply-To: <20111227124009.GG23376@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00840.txt.bz2 On 2011-12-27 20:40, Joel Brobecker wrote: >> Someone said that "MAX_PATH" is not enough about several months ago >> > when we were discussing some breakpoint issue see: >> > http://sourceware.org/ml/gdb/2011-06/msg00101.html > My understanding is: > - The way this function is called, its output is limited to MAX_PATH; > - If the canonialized path does in fact exceed MAX_PATH, then > the canonicalization fails, and we fallback on the old way > (strdup). > > So I do not see the problem with the current approach. There might > be a better implementation, allowing longer paths, but this is > already better than before. And if there is a better implementation > indeed, it does need to work on all supported versions of Windows > (I think we need to support at least as back as XP, possibly older). > > -- Joel Yeah, I agree with you. In fact, I use such patch locally in my XP for months without any problems.:-) asmwarrior ollydbg from codeblocks' forum